BugFix(upstream): correct slice index in function tryTrimIpv6Brackets - #939
Open
Akariln wants to merge 1 commit into
Open
BugFix(upstream): correct slice index in function tryTrimIpv6Brackets#939Akariln wants to merge 1 commit into
tryTrimIpv6Brackets#939Akariln wants to merge 1 commit into
Conversation
The `tryTrimIpv6Brackets` function in `pkg/upstream/utils.go` used an incorrect slice end index when removing square brackets from IPv6 literals. Previously, `s[1:len(s)-2]` truncated the final character (e.g., "[::1]" became "::"). This patch changes the index to `len(s)-1`, ensuring the complete address is returned.
Akariln
changed the title
Akariln
changed the title
tryTrimIpv6Brackets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tryTrimIpv6Bracketsfunction inpkg/upstream/utils.goused an incorrect slice end index when removing square brackets from IPv6 literals. Previously,s[1:len(s)-2]truncated the final character (e.g., "[::1]" became "::"). This patch changes the index tolen(s)-1, ensuring the complete address is returned.