fix(ci): changelog workflow for protected master - #299
Merged
Conversation
Co-authored-by: Isthimius <11380950+Isthimius@users.noreply.github.com>
Copilot
AI
changed the title
chore(core): update pull request
Fix changelog automation for protected Sep 1, 2026
master
master
Isthimius
marked this pull request as ready for review
September 1, 2026 21:38
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change cleanly replaces protected-branch pushes with a PR-based path while preserving the existing change-detection and file-scope validation logic.
Pull request overview
This PR updates the changelog-master GitHub Actions workflow to be compatible with a protected master branch by switching from direct pushes to a PR-based automation flow, while keeping the existing changelog generation and “only CHANGELOG.md files changed” guardrails intact.
Changes:
- Replace direct
git push ... masterpublishing withpeter-evans/create-pull-requesttargetingmasterviaautomation/update-changelogs. - Add
pull-requests: writepermission and gate PR creation on detected changelog changes. - Update scripting documentation to describe the new PR-based workflow behavior.
File summaries
| File | Description |
|---|---|
.github/workflows/changelog-master.yml |
Switches changelog publishing from protected-branch pushes to opening/updating an automation PR against master. |
Tooling/scripts/README.md |
Documents the updated CI behavior (refreshes changelogs and then opens an automation PR). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Isthimius
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update-changelogsActions job was failing because it still tried to push generated changelog commits directly to protectedmaster. This change moves the automation onto a PR-based path while preserving the existing changelog generation and file-scope guardrails.Workflow change
git push origin HEAD:masterin.github/workflows/changelog-master.ymlwithpeter-evans/create-pull-request.pull-requests: writeso it can open or update an automation PR againstmaster.automation/update-changelogs.Behavior preserved
CHANGELOG.mdfiles.Documentation
Tooling/scripts/README.mdto describe the new protected-branch-safe flow.