Skip to content

fix(ci): changelog workflow for protected master - #299

Merged
Isthimius merged 2 commits into
masterfrom
copilot/fix-update-changelogs-job
Sep 1, 2026
Merged

fix(ci): changelog workflow for protected master#299
Isthimius merged 2 commits into
masterfrom
copilot/fix-update-changelogs-job

Conversation

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

The update-changelogs Actions job was failing because it still tried to push generated changelog commits directly to protected master. This change moves the automation onto a PR-based path while preserving the existing changelog generation and file-scope guardrails.

  • Workflow change

    • Replace direct git push origin HEAD:master in .github/workflows/changelog-master.yml with peter-evans/create-pull-request.
    • Grant the job pull-requests: write so it can open or update an automation PR against master.
    • Use a stable automation branch: automation/update-changelogs.
  • Behavior preserved

    • Keep the existing changelog refresh steps unchanged.
    • Keep the validation that fails if the generator modifies anything other than CHANGELOG.md files.
    • Only create a PR when changelog files actually changed.
  • Documentation

    • Update Tooling/scripts/README.md to describe the new protected-branch-safe flow.
- name: Open changelog update pull request
  if: steps.changes.outputs.has_changes == 'true'
  uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1
  with:
    branch: automation/update-changelogs
    base: master
    commit-message: "docs: update unreleased changelogs"
    add-paths: |
      CHANGELOG.md
      **/CHANGELOG.md

@github-actions github-actions Bot changed the title [WIP] Fix failing GitHub Actions job update-changelogs chore(core): update pull request Sep 1, 2026
Co-authored-by: Isthimius <11380950+Isthimius@users.noreply.github.com>
Copilot AI changed the title chore(core): update pull request Fix changelog automation for protected master Sep 1, 2026
Copilot AI requested a review from Isthimius September 1, 2026 21:21
@github-actions github-actions Bot changed the title Fix changelog automation for protected master fix(ci): changelog workflow for protected master Sep 1, 2026
@Isthimius
Isthimius requested a lite review from Copilot September 1, 2026 21:38
@Isthimius
Isthimius marked this pull request as ready for review September 1, 2026 21:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow change cleanly replaces protected-branch pushes with a PR-based path while preserving the existing change-detection and file-scope validation logic.

Pull request overview

This PR updates the changelog-master GitHub Actions workflow to be compatible with a protected master branch by switching from direct pushes to a PR-based automation flow, while keeping the existing changelog generation and “only CHANGELOG.md files changed” guardrails intact.

Changes:

  • Replace direct git push ... master publishing with peter-evans/create-pull-request targeting master via automation/update-changelogs.
  • Add pull-requests: write permission and gate PR creation on detected changelog changes.
  • Update scripting documentation to describe the new PR-based workflow behavior.
File summaries
File Description
.github/workflows/changelog-master.yml Switches changelog publishing from protected-branch pushes to opening/updating an automation PR against master.
Tooling/scripts/README.md Documents the updated CI behavior (refreshes changelogs and then opens an automation PR).
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Isthimius
Isthimius merged commit f9d74e1 into master Sep 1, 2026
21 checks passed
@Isthimius
Isthimius deleted the copilot/fix-update-changelogs-job branch September 1, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants