feat: Add CREATE FUNCTION and DROP FUNCTION privileges support - #72
Merged
Conversation
added 2 commits
October 2, 2025 16:35
REMOTE and S3 privileges get expanded by ClickHouse into READ and WRITE, causing the test to fail when checking privilege counts. This fix filters them out from the global privileges test while still validating them individually.
Collaborator
Author
Additional FixFixed a pre-existing test failure in Why: ClickHouse expands REMOTE and S3 privileges into READ and WRITE privileges internally, causing privilege count mismatches in the test assertions. These privileges are still validated individually in separate test cases. Implementation: Added |
and-longhi
marked this pull request as ready for review
October 2, 2025 15:11
IvanOfThings
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for CREATE FUNCTION and DROP FUNCTION privileges in the ClickHouse Terraform provider, validating that these global privileges can only be used with
database = "*"Changes
database = "*"Test Results
All tests pass successfully: