You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 07ceaf7
Browse filesBrowse the repository at this point in the historyBrowse files
refactor!: hold mapping values in Info or Data, not dict subclasses (#2726) (#2734)
- FrameRecord is an Info rather than a slotted dict subclass, so it is
immutable and no dict. Its mapping is the engine's dissection; packet,
frame_info and time_epoch sit under hidden dunder keys, read through
__getattribute__, so a mapping key of the same name never shadows them.
It pickles through _frame_record, as the 1.5 releases do, and to_dict()
exports the mapping alone.
- TLSKeyLog.entries is a TLSKeyLogEntries data model keyed by label, not a
plain dict, and a mapping given for it is stored as one. to_dict()
exports it as an OrderedMultiDict, as #1484 requires of every level;
TLSKeyLog pickles hold the entries as a dict and restore the model.
- The traced Packet's frame annotation names FrameRecord, and its
versionchanged notes what from_dict(to_dict()) gives back; the pickle
docs drop FrameRecord as their slotted-dict example.
Pickles load across main and 1.5.1 and this change both ways at protocols
0, 1, 2 and 5, except main's own FrameRecord pickles, a format no release
wrote. Dumps and from_data rebuilds match main. New tests fail on main.
0 commit comments