You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5d918b1
Browse filesBrowse the repository at this point in the historyBrowse files
fix(internet): narrow IGMP's id() to self, per owner's post-merge ruling
IGMPv1/IGMPv2 (#2444) shipped with the family-inclusive id() shape --
('IGMP', 'IGMPv1') / ('IGMP', 'IGMPv2') -- but the owner's ruling is
that IGMP narrows to self, like IP/IPsec's AH and ESP:
- IGMP.id() is now ('IGMPv1', 'IGMPv2'), members only, dropping the
family name.
- IGMPv1.id() and IGMPv2.id() are now ('IGMPv1',) and ('IGMPv2',)
alone.
Selector matching for the bare 'IGMP' string is unaffected: it still
resolves via the registry key's own expansion (IGMP class plus its
id()), the same mechanism that already makes 'IPsec' select an AH or
ESP layer. Verified directly against a real parsed IGMPv1 layer:
'IGMP' in layer, 'IGMPv1' in layer and layer == 'IGMPv1' all still
True, 'IGMPv2' in layer still False.
Recorded the ruling in protocol-family-grouping.rst, which previously
had no IGMP entry at all.
Verified: tests/protocols/internet/test_igmp_unit.py,
test_dispatch_registry_unit.py, test_conventions_doc_claims.py and
test_public_api.py all pass clean (91 tests, 1163 subtests).
0 commit comments