Skip to content

Commit 67f588b

Browse files
committed
VERIFY ONLY: compare benchmark runners (#2125)
1 parent abb234d commit 67f588b

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎.github/workflows/benchmark.yml‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ name: Engine Benchmark
1616
# scope, and a report it cannot post is a warning. Nothing here pushes, and the
1717
# docs stay hand-updated from the report.
1818
on:
19+
# VERIFY ONLY (not for merge): compare runners on push to this branch.
20+
push:
21+
branches: [ verify/bench-2125 ]
1922
schedule:
2023
# Wednesdays 03:17 UTC: off the hour, where GitHub delays scheduled runs
2124
# most, and midweek, clear of the Saturday crons (#1967), Monday's Python
@@ -101,7 +104,8 @@ jobs:
101104
timeout-minutes: 300
102105
strategy:
103106
matrix:
104-
os: [ "${{ inputs.runner || 'ubuntu-latest' }}" ]
107+
os: [ ubuntu-latest, ubuntu-26.04-arm, macos-latest, windows-latest ]
108+
fail-fast: false
105109
defaults:
106110
run:
107111
shell: bash
@@ -181,7 +185,7 @@ jobs:
181185
env:
182186
INSTALLED: ${{ needs.python-versions.outputs.engine-ktlo }} ${{ needs.python-versions.outputs.engine-supported }}
183187
PYTHONS: ${{ inputs.pythons }}
184-
ENGINES: ${{ inputs.engines }}
188+
ENGINES: default,dpkt,scapy,pypcap,pcap_ct,pypcapfile
185189
ROUNDS: ${{ inputs.rounds }}
186190
REPEATS: ${{ inputs.repeats }}
187191
RUNNER_LABEL: ${{ matrix.os }}
@@ -242,7 +246,7 @@ jobs:
242246
if: ${{ always() }}
243247
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
244248
with:
245-
name: benchmark-out
249+
name: benchmark-out-${{ matrix.os }}
246250
path: out/
247251
if-no-files-found: ignore
248252
retention-days: 90
@@ -254,7 +258,7 @@ jobs:
254258
discussion:
255259
name: Post the engine benchmark report
256260
needs: [ benchmark ]
257-
if: ${{ always() && needs.benchmark.result != 'skipped' }}
261+
if: false
258262
runs-on: ubuntu-latest
259263
timeout-minutes: 10
260264
continue-on-error: true

0 commit comments

Comments
 (0)