Repository navigation
Commit 7cb1c25
committed
fix(tcp): Quick-Start Response reader reads a stray octet; maker fails below 40 kbps
- _read_mode_qs read one octet past the option before its length check, so
every Quick-Start Response failed with "StructError: unpack: empty buffer".
- _make_mode_qs took floor(log2(rate / 40)), negative for rates under 40 kbps,
which cannot pack into the 4-bit field. Clamp to N = 0: RFC 4782 Section 3.1
defines N = 0 as a rate of zero, and Section 4.3 lets a response report a
lower rate than requested.
- Drop the tcp-option/Quick_Start_Response EXPECTED_FAILURES entry, now closed.
- Add tests/protocols/transport/test_tcp_quick_start_response_unit.py.
Closes #11191 parent a7ef878 commit 7cb1c25
3 files changed
Lines changed: 88 additions & 13 deletions
File tree
- pcapkit/protocols/transport
- tests/protocols
- transport
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1348 | 1348 | | |
1349 | 1349 | | |
1350 | 1350 | | |
1351 | | - | |
1352 | 1351 | | |
1353 | 1352 | | |
1354 | 1353 | | |
| |||
2576 | 2575 | | |
2577 | 2576 | | |
2578 | 2577 | | |
2579 | | - | |
| 2578 | + | |
| 2579 | + | |
| 2580 | + | |
| 2581 | + | |
2580 | 2582 | | |
2581 | 2583 | | |
2582 | 2584 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | 140 | | |
152 | 141 | | |
153 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
0 commit comments