Skip to content

Commit 894aebc

Browse files
committed
ci: fix shellcheck findings and trim comments in unit-tests.yml (#1967)
Step 5, part 2 of #1967, over unit-tests.yml: - Fix the SC2086 in pypcap-parity's "Run full test suite": split the selection with `read -ra` into an array, and do the same in integration's and project-tests' pytest steps, dropping their `shellcheck disable=SC2086`. Same words reach pytest, with no pathname expansion. - Trim comments: drop restatements of the YAML, history narration, measurements already in the issues, and rationale repeated across jobs; keep each non-obvious why, its issue ref, and the phrases tests pin. - Add test_unit_tests_shellcheck_1967.py, which runs shellcheck over every bash run: block as actionlint 1.7.12 does, skipping without shellcheck. actionlint 1.7.12 reports nothing on unit-tests.yml; the workflow tests pass.
1 parent 657be8d commit 894aebc

3 files changed

Lines changed: 417 additions & 786 deletions

File tree

‎.github/workflows/lint.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ jobs:
6565
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
6666

6767
# actionlint checks every workflow, running the image's shellcheck over
68-
# each `run:` block. First, as it needs no Python. It stays advisory while
69-
# shellcheck findings remain in unit-tests.yml and experimental.yml (#1967).
68+
# each `run:` block. First, as it needs no Python. It is advisory; whether
69+
# it should block now that it reports nothing is open on #1967.
7070
#
7171
# The release binary is pinned by version and sha256, from the release's
7272
# checksums file. Dependabot does not see this pin; bump both together.

0 commit comments

Comments
 (0)