Repository navigation
Commit 894aebc
committed
ci: fix shellcheck findings and trim comments in unit-tests.yml (#1967)
Step 5, part 2 of #1967, over unit-tests.yml:
- Fix the SC2086 in pypcap-parity's "Run full test suite": split the
selection with `read -ra` into an array, and do the same in
integration's and project-tests' pytest steps, dropping their
`shellcheck disable=SC2086`. Same words reach pytest, with no
pathname expansion.
- Trim comments: drop restatements of the YAML, history narration,
measurements already in the issues, and rationale repeated across
jobs; keep each non-obvious why, its issue ref, and the phrases
tests pin.
- Add test_unit_tests_shellcheck_1967.py, which runs shellcheck over
every bash run: block as actionlint 1.7.12 does, skipping without
shellcheck.
actionlint 1.7.12 reports nothing on unit-tests.yml; the workflow tests
pass.1 parent 657be8d commit 894aebc
3 files changed
Lines changed: 417 additions & 786 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
| 68 | + | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
0 commit comments