Repository navigation
Commit c2ee06a
committed
fix(ci): act on a Unit Tests verdict only for the commit it covers (#1643)
Conda Update, Vendor Update and GitHub Pages check out github.sha, main's
tip when the workflow_run is raised, not the commit the completed Unit Tests
run verified. In a merge wave an older commit's success authorised work on an
untested tip: Conda Update 38325136710 bumped 2e941bb under 9083163's
verdict.
- Add a `verdict` job to each, running util/verdict_covers_checkout.py. It
accepts the tip when it is the verified commit, or that commit plus
github-actions[bot] commits to conda/build and conda/requirements.txt only.
The acting job's workflow_run clause now also needs `verified == 'true'`.
- Key the workflow-level concurrency group on the verdict's sha for a
workflow_run, so a stale run that skips cannot cancel a pending run whose
verdict matches. Other events keep their groups.
- workflows.rst: describe the check and what it leaves uncovered, and
renumber the three `uses:` citations.
tests/project/test_workflow_run_verdict.py: 25 pass. With origin/main's three
workflows swapped in, 9 fail (failures=22, subtests counted); with the verdict
checkout at fetch-depth 1, 1 fails in all three workflows. A merge whose side
branch runs past the shallow checkout is refused with exit 0, not a crash.
Its throwaway repos run no git maintenance: since git 2.54 a commit's detached
auto repack raced their cleanup ("Directory not empty", git 2.55.0).
Closes #16431 parent b375656 commit c2ee06a
6 files changed
Lines changed: 813 additions & 22 deletions
File tree
- .github/workflows
- docs/source/contributing
- tests/project
- util
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
26 | 33 | | |
27 | 34 | | |
28 | 35 | | |
29 | 36 | | |
30 | | - | |
| 37 | + | |
31 | 38 | | |
32 | 39 | | |
33 | 40 | | |
| |||
44 | 51 | | |
45 | 52 | | |
46 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
47 | 89 | | |
48 | 90 | | |
49 | 91 | | |
50 | | - | |
| 92 | + | |
51 | 93 | | |
52 | 94 | | |
53 | 95 | | |
54 | 96 | | |
55 | 97 | | |
56 | 98 | | |
57 | | - | |
58 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
59 | 102 | | |
60 | 103 | | |
61 | 104 | | |
| |||
65 | 108 | | |
66 | 109 | | |
67 | 110 | | |
68 | | - | |
| 111 | + | |
| 112 | + | |
69 | 113 | | |
70 | 114 | | |
71 | 115 | | |
| |||
90 | 134 | | |
91 | 135 | | |
92 | 136 | | |
93 | | - | |
| 137 | + | |
| 138 | + | |
94 | 139 | | |
95 | 140 | | |
96 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
32 | 39 | | |
33 | 40 | | |
34 | 41 | | |
35 | 42 | | |
36 | | - | |
| 43 | + | |
37 | 44 | | |
38 | 45 | | |
39 | 46 | | |
| |||
50 | 57 | | |
51 | 58 | | |
52 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
53 | 95 | | |
54 | 96 | | |
55 | | - | |
| 97 | + | |
56 | 98 | | |
57 | 99 | | |
58 | 100 | | |
59 | 101 | | |
60 | 102 | | |
61 | 103 | | |
62 | | - | |
63 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
64 | 107 | | |
65 | 108 | | |
66 | 109 | | |
| |||
69 | 112 | | |
70 | 113 | | |
71 | 114 | | |
72 | | - | |
| 115 | + | |
| 116 | + | |
73 | 117 | | |
74 | 118 | | |
75 | 119 | | |
| |||
94 | 138 | | |
95 | 139 | | |
96 | 140 | | |
97 | | - | |
| 141 | + | |
| 142 | + | |
98 | 143 | | |
99 | 144 | | |
100 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
32 | 40 | | |
33 | | - | |
| 41 | + | |
34 | 42 | | |
35 | 43 | | |
36 | 44 | | |
| |||
48 | 56 | | |
49 | 57 | | |
50 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
51 | 94 | | |
52 | | - | |
| 95 | + | |
53 | 96 | | |
54 | 97 | | |
55 | 98 | | |
56 | 99 | | |
57 | 100 | | |
58 | 101 | | |
59 | 102 | | |
60 | | - | |
61 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
62 | 106 | | |
63 | 107 | | |
64 | 108 | | |
| |||
67 | 111 | | |
68 | 112 | | |
69 | 113 | | |
70 | | - | |
| 114 | + | |
| 115 | + | |
71 | 116 | | |
72 | 117 | | |
73 | 118 | | |
| |||
86 | 131 | | |
87 | 132 | | |
88 | 133 | | |
| 134 | + | |
| 135 | + | |
89 | 136 | | |
90 | 137 | | |
91 | 138 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
200 | | - | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
201 | 203 | | |
202 | 204 | | |
203 | 205 | | |
| |||
224 | 226 | | |
225 | 227 | | |
226 | 228 | | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
227 | 242 | | |
228 | 243 | | |
229 | 244 | | |
| |||
234 | 249 | | |
235 | 250 | | |
236 | 251 | | |
237 | | - | |
| 252 | + | |
238 | 253 | | |
239 | | - | |
| 254 | + | |
240 | 255 | | |
241 | | - | |
| 256 | + | |
242 | 257 | | |
243 | 258 | | |
244 | 259 | | |
| |||
0 commit comments