Repository navigation
Commit c2f1089
authored
Round 10, the closing-condition test: a full re-grep across the entire repo
found exactly 3 items, all outside the carve-outs round 9 already settled.
* pcapkit/protocols/protocol.py + foundation/registry/protocols.py:
RegistryError said "protocol must be a Protocol subclass" while the
adjacent issubclass() check and the Raises: docstring both say
ProtocolBase -- fixed the message text to match, with the three test
assertions that locked the old string.
* tests/foundation/reassembly/test_deferred_pickle_2423_unit.py: a docstring
said "this pull request's earlier commit", stale now that #2424 landed as
one squashed commit on main -- reworded to cite the issue instead of the
PR's own history.
* tests/protocols/transport/test_tcp_mptcp_option_attr_2293_unit.py: a
cross-reference cited the nonexistent module
pcapkit.corekit.fields.enums.EnumField; the real path is
pcapkit.corekit.fields.numbers.EnumField.
No executable logic changed: an AST structural diff (ignoring string
constants) against origin/main is identical for every touched file, and the
RegistryError fix only changes the text of a raised message, not what
triggers it.
Re-verified and rejected two relayed findings that didn't survive a direct
check: a transport.py:188-189 and a registry/protocols.py:370 cross-reference
claim both already read correctly on this base. Re-swept vendor/process()
for siblings of #2429/#2430 -- none found. docs/source and the rest of
tests/ came back clean.
Build: tests/protocols/test_register_class_guard_unit.py,
tests/foundation/registry/test_protocols.py,
tests/foundation/reassembly/test_deferred_pickle_2423_unit.py,
tests/protocols/transport/test_tcp_mptcp_option_attr_2293_unit.py and
tests/project/test_docs_issue_pr_roles_1103_unit.py pass.
Closes #1103.
1 parent 857bd52 commit c2f1089
6 files changed
Lines changed: 9 additions & 9 deletions
File tree
- pcapkit
- foundation/registry
- protocols
- tests
- foundation
- reassembly
- registry
- protocols
- transport
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1139 | 1139 | | |
1140 | 1140 | | |
1141 | 1141 | | |
1142 | | - | |
| 1142 | + | |
1143 | 1143 | | |
1144 | 1144 | | |
1145 | 1145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
247 | | - | |
248 | | - | |
249 | | - | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
441 | | - | |
| 441 | + | |
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments