You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit cfbe5dc
Browse filesBrowse the repository at this point in the historyBrowse files
docs: #1103 round 8 -- finish the Protocol/ProtocolBase cross-reference sweep, fix other prose drift (#2428)
Round 8 of the whole-repo prose sweep (#1103). Fanned out 8 shard agents by
directory; most of the repo was clean. Changes:
* pcapkit/protocols/internet/ipv6_ext.py + its .rst: finish the carry-over
miss from round 7 -- the `_lookup_next_layer` plain pointer still targeted
`ProtocolBase`, flipped to `Protocol` per #2420's ruling.
* Same miss in corekit/sentinels.py (`__keywords__`), docs/source/ext.rst
(three sites, including a verbatim twin of a paragraph #2420 already fixed
in protocol.py), schema/schema.py and schema/link/ethernet.py.
* internet.py, link.py, transport.py, sctp.py, protocol.py: `register()`'s
Arguments: and a couple of Returns:/versionchanged clauses said `Protocol`
subclass/instance while the signature types `ProtocolBase` and the
adjacent Raises: clause already said so -- internal contradiction, fixed
to `ProtocolBase` to match.
* docs/source/contributing/conventions/protocol-layer-placement.rst: the
Link-Application-ProtocolBase set difference is `__proto_key__`, not
empty as claimed (#2343 added it after this page was written).
* docs/source/contributing/conventions/registry-protocol.rst: "every
registry overrides `_validate_value`" contradicted its own next
paragraph, where the AppType transports inherit rather than override.
* pcapkit/vendor/ipx/packet.py, vendor/reg/linktype.py: a self-contradicting
claim and a stale counted-number, both in vendor docstrings.
* docs/source/engines.rst, docs/source/conf.py, util/changelog_md.py,
CONTRIBUTING.md: a stale scapy version, a wrong file path, a false
"matches the Sphinx we build with" claim, and a missing caveat about
actionlint making Lint non-advisory.
No executable code changed -- every edit is inside a docstring, comment, or
.rst file; confirmed by diff review and `import pcapkit` from this worktree.
Four behavioral defects found but deliberately left unfixed (reported
separately): 16 of 24 pcapkit/vendor crawlers' `process(self, data)` reads
the module-global `DATA` instead of its own `data` argument (latent,
harmless only because `request()` returns that same global); an empty
`FilterType` registry behind a live TODO; three open "handle this
programmatically" TODOs in pcapkit/vendor/mh; and dead `multiprocessing.Pool`
scaffolding in vendor/__main__.py.
0 commit comments