fix(vendor): 16 crawlers' process() reads its own data argument (#2429) (#2430)

16 of the 24 dict-based crawlers' `process(self, data)` ignored the `data`
argument and read the module-level `DATA` literal instead: `ipv4/qs_function`,
`tos_del`, `tos_ecn`, `tos_pre`, `tos_rel`, `tos_thr`, `ts_flag`;
`ipv6/option_action`, `qs_function`, `smf_dpd_mode`; `mh/binding_error`,
`lla_code`; and `pcapng/filter_type`, `hash_algorithm`, `secrets_type`,
`verdict_type`. 8 siblings, such as `ipv4/classification_level`, already use
`data` correctly.

Harmless today, since every real call site passes `request()`'s own
`DATA`-returning value, so `data is DATA` always held in practice -- but a
caller passing different data, such as a test fixture or a future
`LINK`-based fetch (the open TODO in `pcapng/filter_type.py` already points
that direction), got the module's table back regardless, with no error.

`pcapkit-vendor` regenerates `pcapkit/const/`, not `pcapkit/vendor/` itself:
these dict-based crawlers are hand-written, so no template needed the same
fix and no `const/` regeneration follows from it.

New test drives each crawler's `count()` and `process()` on a fabricated
registry sharing none of the module's names, proving the rendered output now
reflects the argument rather than the module global; confirmed to fail
against the unfixed crawlers first.

Closes #2429.

Author: JarryShaw

CHANGELOG.md

@@ -457,6 +457,7 @@ This resolves [#548](https://github.com/JarryShaw/PyPCAPKit/issues/548), which r
 - the generated const comments render as written: a URL reference followed by another bracket no longer autolinks into it, a leading enumerator such as `(S)` is escaped, and a hyphenated word is no longer split across lines ([#1846](https://github.com/JarryShaw/PyPCAPKit/issues/1846), [#1847](https://github.com/JarryShaw/PyPCAPKit/issues/1847), [#1871](https://github.com/JarryShaw/PyPCAPKit/pull/1871)).
 - without the `vendor` extra, `pcapkit-vendor` and `python -m pcapkit.vendor` exit 1 with one line naming the missing packages and `pypcapkit[vendor]`, where they died with a traceback, and `--help` and `--version` still work. Importing a crawler then raises `ModuleNotFoundError` ([#1850](https://github.com/JarryShaw/PyPCAPKit/issues/1850), [#1875](https://github.com/JarryShaw/PyPCAPKit/pull/1875)).
 - the ESP cipher and integrity crawlers strip the brackets off IANA's `[UNSPECIFIED]` "no document" cell before testing it against the unknown placeholder, so `pcapkit.const.esp.integrity` no longer reads `#: AUTH_DES_MAC [UNSPECIFIED] (DEPRECATED ...)` for `AUTH_DES_MAC` and `AUTH_KPDK_MD5` ([#2294](https://github.com/JarryShaw/PyPCAPKit/issues/2294), [#2371](https://github.com/JarryShaw/PyPCAPKit/pull/2371)).
+- some dict-based crawlers' `process(self, data)` ignored the `data` argument and read the module-level `DATA` literal instead, in `ipv4/{qs_function,tos_del,tos_ecn,tos_pre,tos_rel,tos_thr,ts_flag}.py`, `ipv6/{option_action,qs_function,smf_dpd_mode}.py`, `mh/{binding_error,lla_code}.py` and `pcapng/{filter_type,hash_algorithm,secrets_type,verdict_type}.py`. Harmless today, since every real call site passes `request()`'s own `DATA`-returning value, so `data is DATA` always held in practice -- but a caller passing different data, such as a test fixture or a future `LINK`-based fetch, got the module's table back regardless, with no error. The dict-based crawlers are hand-written rather than generated, so the fix needs no `const/` regeneration ([#2429](https://github.com/JarryShaw/PyPCAPKit/issues/2429), [#2430](https://github.com/JarryShaw/PyPCAPKit/pull/2430)).
 
 ### Project infrastructure
 

docs/source/changelog/1.5.0.rst

@@ -3350,6 +3350,18 @@ Fixed
   placeholder, so :mod:`pcapkit.const.esp.integrity` no longer reads
   ``#: AUTH_DES_MAC [UNSPECIFIED] (DEPRECATED ...)`` for ``AUTH_DES_MAC`` and
   ``AUTH_KPDK_MD5`` (:issue:`2294`, :pr:`2371`).
+* some dict-based crawlers' ``process(self, data)`` ignored the ``data``
+  argument and read the module-level ``DATA`` literal instead, in
+  ``ipv4/{qs_function,tos_del,tos_ecn,tos_pre,tos_rel,tos_thr,ts_flag}.py``,
+  ``ipv6/{option_action,qs_function,smf_dpd_mode}.py``,
+  ``mh/{binding_error,lla_code}.py`` and
+  ``pcapng/{filter_type,hash_algorithm,secrets_type,verdict_type}.py``. Harmless
+  today, since every real call site passes ``request()``'s own
+  ``DATA``-returning value, so ``data is DATA`` always held in practice -- but a
+  caller passing different data, such as a test fixture or a future ``LINK``-based
+  fetch, got the module's table back regardless, with no error. The dict-based
+  crawlers are hand-written rather than generated, so the fix needs no ``const/``
+  regeneration (:issue:`2429`, :pr:`2430`).
 
 Project infrastructure
 ----------------------

pcapkit/vendor/ipv4/qs_function.py

@@ -68,7 +68,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code)  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv4/tos_del.py

@@ -68,7 +68,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code).upper()  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv4/tos_ecn.py

@@ -85,7 +85,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code)
             enum.append(f"{renm} = 0b{bin(code)[2:].zfill(2)}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv4/tos_pre.py

@@ -74,7 +74,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code)  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv4/tos_rel.py

@@ -68,7 +68,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code).upper()  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv4/tos_thr.py

@@ -68,7 +68,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code).upper()  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv4/ts_flag.py

@@ -69,7 +69,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code)  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss

pcapkit/vendor/ipv6/option_action.py

@@ -80,7 +80,7 @@ def process(self, data: 'dict[int, str]') -> 'tuple[list[str], list[str]]':  # t
         miss = [
             "return cls._unregistered_member(value, 'Unassigned')",
         ]
-        for code, name in DATA.items():
+        for code, name in data.items():
             renm = self.rename(name, code)  # type: ignore[arg-type]
             enum.append(f"{renm} = {code}".ljust(76))
         return enum, miss