Repository navigation
Closed
Labels
bugIssues reporting a defect (set by the bug report template; a default, not an assessment)Issues reporting a defect (set by the bug report template; a default, not an assessment)ciPull requests that change CI or workflow configuration (ci: subject prefix)Pull requests that change CI or workflow configuration (ci: subject prefix)testPull requests that add or correct tests (test: subject prefix)Pull requests that add or correct tests (test: subject prefix)
Milestone
Description
Two related findings.
- CI never runs
tests/corekitunder plain unittest. Theunittest-orderingmatrix inunit-tests.ymllists cli, const, dumpkit, foundation, interface, project, protocols/internet, toolkit, utilities, vendor and protocols (rest). It has nocorekitleg and nointegrationleg. Theintegrationone may be deliberate; if so it should be documented. - That leg fails on
main.python util/run_unittest_leg.py corekitataeb4aadd3gives 903 tests with 34 failures and 31 errors. fix(corekit): let Windows reopen SeekableReader's buffer file (#2098) #2105's head, merged intomain, gives the identical failure set.- Where: all of them are in
test_enum_lookup_reparent_930_unit(15+),test_enum_lookup_reparent_877_unit(10) andtest_enum_get_exception_provenance_923_unit(7+). - Symptoms:
Tuples differ: (<class 'pcapkit.corekit.enum.EnumLookup'>, <aenum 'IntEnum'>) != (<class 'pcapkit.corekit.enum.EnumLookup'>, <aenum 'IntEnum'>). The reprs are identical, so the class objects differ.EnumLookup not found in (<flag 'Flags'>, …).EnumKeyErrorwhere the test expectsEnumValueError.
- Inferred, not proven: an earlier module in the same process re-imports or reloads
pcapkit.corekit.enum, or a const module. The later tests then compare against a staleEnumLookup. pytest's per-worker processes would hide this.
- Where: all of them are in
Proposed:
- find the polluting module and make it restore
sys.modules, or make the comparisons identity-safe if that is the intent; - add
corekitto the ordering matrix (andintegration, or document why not), with a test that pins the matrix covers everytests/subdirectory.
Metadata
Metadata
Assignees
Labels
bugIssues reporting a defect (set by the bug report template; a default, not an assessment)Issues reporting a defect (set by the bug report template; a default, not an assessment)ciPull requests that change CI or workflow configuration (ci: subject prefix)Pull requests that change CI or workflow configuration (ci: subject prefix)testPull requests that add or correct tests (test: subject prefix)Pull requests that add or correct tests (test: subject prefix)
Projects
- StatusShow more project fieldsDone
Activity
test(corekit): import EnumLookup per test so later enum tests see one…
ci: run the corekit plain-unittest ordering leg (#2115) (#2116)