You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(pcapng): make(block=<bytes>) for a DSB raises AttributeError, not handled #2354
PCAPNG.make(block=<bytes>) for a Decryption Secrets Block raises AttributeError: 'bytes' object has no attribute 'length', even though block is typed to accept bytes.
Evidence
Found while reviewing #2346, on origin/main as well as the PR head — not caused by that PR.
Expected behavior
A raw bytes block should be handled the same way the short-block path (hasattr(block, 'block_raw')) is, or make() should raise a ProtocolError naming the problem rather than an AttributeError.
Activity
fix(pcapng): handle make(block=<bytes>) for a DSB (#2354)
fix(pcapng): handle make(block=<bytes>) for a DSB (#2354) (#2370)