Skip to content

IPv4 checksum verification and computation (one's-complement, queued with #2470/#2471) #2472

Open

Description

@JarryShaw

IPv4 checksum verification and computation (one's-complement, queued with #2470/#2471)

Summary

Part of the owner's 2026-10-30 ruling on #2470: the one's-complement checksum work for IPv4/TCP/UDP/ICMP/ICMPv6/OSPF is queued and done together rather than piecemeal, through #2471's shared pseudo-protocol class.

  • pcapkit.protocols.internet.ipv4.IPv4.read() does not verify the wire checksum field; a corrupted capture parses silently.
  • pcapkit.protocols.internet.ipv4.IPv4.make() leaves checksum unset/zero rather than computing the real checksum (RFC 791 §3.1, header checksum only (no pseudo-header needed for IPv4 itself)).

Scope

Follows the Protocol class conventions, using #2471's pseudo-protocol class for any value from the enclosing IP layer this checksum needs. See docs/source/contributing/pep.rst, "Checksum and Integrity Verification", for the full cross-protocol plan.

Blocked on

#2471 (the shared pseudo-protocol class) landing first.

Activity

  1. added
    enhancementIssues requesting a new capability (set by the feature request template)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 30, 2026
  2. added this to the PyPCAPKit v1.5 milestone on Oct 30, 2026
  3. moved this to Blocked in PyPCAPKiton Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedDeferred pending another issue or decision; see the last comment for what unblocks itenhancementIssues requesting a new capability (set by the feature request template)

    Projects

    • Status
      Blocked

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions