Repository navigation
docs: prose sweep after the defect wave (protocols) (#1103) - #1180
Merged
Merged
Conversation
Correct two statements the wave's code changes made inaccurate: - http.py: the HTTP/2 fall-through arm no longer accepts any self-consistent nine-octet buffer; it is gated by _test_http2_frame. The fault-injection measurement is scoped to the ungated arm. - protocol.py: _parse_next_layer counts captured octets as min(length, len(file_)), not all of file_. Comments and docstrings only; AST unchanged.
Owner
Author
|
Cross-review verdict on
|
Contributor
|
Coverage: 88.89% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
make pylint,make mypy,make isort) — not run; comments and docstrings onlymake testpasses, and a test case covers the change — per-module runs below; prose onlyWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Part of #1103. Protocols slice: 18 wave-touched files read, 2 changed.
application/http.py: two_guess_versioncomments said the HTTP/2 fall-through accepts any self-consistent nine-octet buffer. It is now gated by_test_http2_frame. The fault-injection measurement is scoped to the ungated arm: no HTTP/1 start line passes the gate, because its octet 3 is never a frame type 0-9.protocol.py: the_parse_next_layernote said the captured octets are all offile_. The code usesmin(length, len(file_)).Tests:
test_http_guess_http2_1141_unit5 passed;test_http_unit65 passed;test_next_layer_short_header_unit7 passed;test_protocol_base_unit15 passed;tests/project389 passed, 1 skipped.pcapkit/protocols/application/http.pypcapkit/protocols/protocol.py