Repository navigation
docs(protocols): seventh whole-repo pass over application, misc and the protocol bases (#1103) - #2262
Merged
Merged
Conversation
Owner
Author
|
Review: GOOD TO GO at
|
Merged
5 tasks done
…he protocol bases (#1103) Full read of pcapkit/protocols/application, misc (PCAP, PCAP-NG), the protocol/schema/data base modules and their data/schema models. - PCAP-NG: nanosecond claim, tzone types, draft sections by name, Returns. - PCAP/PCAP-NG schemas and data: BlockType warns, negative lengths, Header.read Raises, NoPayload, IF_TSRESOL, aenum.StrEnum, journal data. - Protocol/Schema bases: expand_comp, _read_unpack Raises, __init_subclass__, Schema.__new__/from_dict, change-relative wording. - Application: PRI is registered (RFC 7540 section 11.6), its 24-bit value, HTTP.pack, FrameType comment, OSPF Raises. - NGAP: PPID 60/66 named as the SCTP registry spells them.
JarryShaw
force-pushed
the
docs/1103-r7-appmisc-pr
branch
from
October 26, 2026 19:03
401d270 to
c41c41c
Compare
Owner
Author
|
Review: GOOD TO GO at
|
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, round 7. A full read of
pcapkit/protocols/application,misc(PCAP, PCAP-NG), the protocol/schema/data base modules and their models. Prose only: the AST guard is identical on all 10.pyfiles.nanosecondis true for any resolution finer than microseconds._make_option_if_tzoneaccepts the types listed._read_secrets_*haveReturns:sections.BlockType.post_processwarns rather than raising.SchemaFieldlength reads the rest.Header.readraisesProtocolErrorfrom the magic callback.NoPayload._protos,IF_TSRESOL,aenum.StrEnum, the journaldata.expand_comp, the_read_unpackRaises,__init_subclass__scope, theSchema.__new__/from_dictbullets, and the "We used…" comments.PRIis registered (RFC 7540 §11.6), andb'PRI'as 24 bits is 5,263,945.HTTP.packwrites the preface.OSPF.makeRaises covers a dict missing keys.tests/protocols/misc/290 passed,tests/protocols/application/249; docs, docstring-contract and convention tests pass.