Repository navigation
docs(link,transport): seventh whole-repo pass over link and transport protocols (#1103) - #2263
Merged
Merged
Conversation
… protocols (#1103) Full read of pcapkit/protocols/link, transport and their data/schema models. - L2TP: the tunnel ID is the Session ID's lower half; L2TPv2.read's version check and Raises. - ARP/Ethernet make: Raises name the address makers' exceptions. - SCTP: padding clamp per RFC 9260 section 3.2, folded padding chunks, SACK a_rwnd, PPID member names. - TCP: Flags has its own _missing_; FieldValueError in MPTCP Raises.
Owner
Author
|
Review: GOOD TO GO at
|
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, round 7. A full read of
pcapkit/protocols/link,transportand their models. Prose only: the AST guard is identical on all 7.pyfiles.L2TPv2.readdocuments its version check.makeRaises name what the address makers raise (fix(ethernet,pcapng): reject a non-string MAC or EUI address (#2222) #2232, fix(arp): prefix the hardware-address messages and reject a bool with ProtocolError (#2256) #2257).a_rwndminimum applies to INIT only.Flagshas its own_missing_;FieldValueErroradded to the MPTCP Raises.tests/protocols/link113 passed,tests/protocols/transport245; docs and docstring-contract tests pass.