Repository navigation
docs(corekit,const,vendor): seventh whole-repo pass over corekit, const and vendor (#1103) - #2264
Merged
Merged
Conversation
…st and vendor (#1103) Full read of pcapkit/corekit, the vendor crawlers and templates, the hand-written const prose and their API pages. - corekit: FieldBase.unpack example, _nested_types target, EnumRegistry covers open enums only, parse_ip_address claim narrowed, NoDefaultType and parse_ip_address change-relative wording. - vendor: Method.get and _sanitize_identifier template text (mirrored into the generated const modules), TLSKeyLabel, AppType Record/svc, mh flag process Returns, L2TP process, ipx RFC sections by name, PCAP-NG Hash Algorithms anchor, ExtensionHeader/EtherType comments. - const: index page raise bands and source data, PCAP-NG anchor, VLAN class role, OSPF title underline.
Owner
Author
|
Review: GOOD TO GO at
|
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, round 7. A full read of
pcapkit/corekit, the vendor crawlers and templates, the hand-written const prose, and their API pages. Prose only..pyfiles are identical with docstrings stripped.vendor/ftp/command.py,vendor/http/method.pyandvendor/reg/apptype/apptype.py.FieldBase.unpackexample and the_nested_typestarget are corrected.EnumRegistrycovers open enums only.parse_ip_address"nothing catches it" claim is narrowed to what holds.Method.get(the constructor finds hyphenated values before_missing_) and the_sanitize_identifierguard pointer are fixed.TLSKeyLabel.process, AppTypeRecord/svc, the mh flagprocessReturns, and L2TPprocess.:class:role and the OSPF title underline.tests/const/365 passed,tests/vendor/169, thetests/corekitnearest selection 375; docs, docstring-contract and convention tests pass.