[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• test — tests only

---

Description

Part of #1103, round 7. A full read of every docstring and comment under tests/, in 20 slices. Docstrings and comments only: the AST guard (docstrings stripped) is identical on all 271 files. Test names, assertion messages and string literals are unchanged, and the ones that need it are filed separately.

• protocols/vendor/const/integration:
  • Stale claims fixed:
    • RFC 6621 §6.1.1, RFC 8200 §4, RFC 3931 §4.1.2.1 and RFC 9113 §3;
    • the L2TP tunnel ID is the lower half;
    • the MPTCP ADD_ADDR misread, and SCTP 0xFFF0;
    • b'PRI'/b'foo' as 24-bit values;
    • HIP_COPIES is 1;
    • the test/gate jobs install vendor.
  • Wording: change-relative narratives and counts are restated.
• project:
  • Claims are checked against the workflows, util scripts, docs and pyproject.
  • The ci: divide and simplify the workflows into scripts, shared heads and smaller files #1967 parity tests call the inline shell form the reference the script must match.
  • The release-gate and CI narratives are stated without history; a verbatim quote is paraphrased.
• corekit/foundation/utilities/toolkit/dumpkit/interface/cli/root:
  • "Without the fix" restatements, stale claims (_dependency_gates, _tiers, the docstring contract) and counts.
  • GH#NNN comment references become #NNN.
  • Never-released names are dropped from docstrings.
• Tests: every touched file, run per slice, passes. The tier guard, docstring contract, issue-refs and conventions tests pass on the combined tree (180 passed).

[JarryShaw]

Review: GOOD TO GO at 81ed25717 (Sonnet).

• Docstrings and comments only: the AST guard with docstrings stripped is identical on all 271 files, so test names, string literals, messages and labels are unchanged.
• Tests:
  • Every changed directory was run in narrow batches; all passed (project, foundation, corekit, utilities, toolkit, interface, cli, dumpkit, const, vendor, integration, and all of protocols).
  • The text-pin set gives 208 passed: tier guard, docstring contract, issue-refs, conventions and module isolation.
• Claims: about 30 claims spot-checked against the RFCs, the workflows and the code all hold:
  • RFC 6621 §6.1.1, RFC 3931 §4.1.2.1, RFC 9113 §3;
  • b'PRI' = 5263945;
  • HIP_COPIES = 1;
  • the MPTCP predicate;
  • the .[all,dev] installs.
• House rules: no never-released names are introduced.
• Next round: two small prose nits, the test_hip_r1_counter_width_unit scenario (two copies) and a count in test_per_class_import_guard.

[github-actions]

Coverage: 91.56% (unit tier, Python 3.15, 81ed25717, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	74	816	37	96.51%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	3023	23	1044	25	98.82%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17437	218	4586	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.