Repository navigation
fix(httpv2)!: default RST_STREAM and GOAWAY to NO_ERROR (#2311) - #2337
Conversation
|
Review: GOOD TO GO at
|
a90b72a to
1f032f8
Compare
|
Rebased The old head's |
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
1f032f8 to
eb18a59
Compare
|
Rebased The old head's CI was green ( Since the patch is unchanged and the old head was already green, the owner can bypass checks and merge once the new head's CI completes — this only re-establishes a path through the required contexts on top of |
Problem: HTTP._make_http_rst_stream and HTTP._make_http_goaway defaulted
error to HTTP_1_1_REQUIRED (0xd), so a frame built without an error code
asked the peer to use HTTP/1.1 instead.
Fix: both default to NO_ERROR (0x0), per RFC 9113 section 7; docstrings
carry a versionchanged note, and the 1.5.0 changelog records the breaking
change (CHANGELOG.md regenerated).
Test: test_httpv2_error_default_2311_unit.py builds both frames with
frame={} and pins the emitted error-code octets as zero, and an explicit
error as still honoured.
eb18a59 to
325659a
Compare
|
Rebased again On the new head: My earlier note on this PR described a clean rebase against an older |
make testpasses, and a test case covers the change1.5.0.rst(breaking change)What is the purpose of your pull request?
fix — bug fixDescription
Closes #2311, per the ruling (take the recommendation). Breaking: the default error code changes.
HTTP._make_http_rst_streamandHTTP._make_http_goawaydefaultederrortoHTTP_1_1_REQUIRED(0xd). A frame built without an error code therefore asked the peer to fall back to HTTP/1.1. Both now default toNO_ERROR(0x0), per RFC 9113 §7. The docstrings carry aversionchangednote.1.5.0.rstrecords the breaking change, andCHANGELOG.mdis regenerated withutil/changelog_md.py.test_httpv2_error_default_2311_unit.pybuilds both frames withframe={}, pins the error-code octets as zero, and checks that an explicit error is still honoured.origin/main, 2 failed (the last octet is\r, not\x00). On the head, 3 passed.