Repository navigation
fix(vendor): drop the bracketed [UNSPECIFIED] from ESP Integrity comments (#2294) - #2371
Conversation
|
Review: GOOD TO GO at |
…ents (#2294) Integrity.rfcs tested the whole cell against UNKNOWN, but IANA spells the "no document" cell "[UNSPECIFIED]", brackets included, so it passed through and pcapkit.const.esp.integrity read "#: AUTH_DES_MAC [UNSPECIFIED] (DEPRECATED [:rfc:`8247`])", and the same for AUTH_KPDK_MD5. Strip one pair of surrounding brackets before the UNKNOWN test, in Integrity.rfcs and in Cipher.rfcs, which shares the check. The const file is regenerated by running the crawler against the live registry; cipher.py regenerates unchanged. Test: test_esp_unspecified_reference_2294_unit checks both crawlers' rfcs on bracketed and bare placeholders and renders the recorded registry into the committed integrity.py.
19136d4 to
fe5dd8c
Compare
|
Rebased and amended All review findings now addressed. |
|
Coverage: 91.64% (unit tier, Python 3.15,
Per-file detail: the |
|
Ready to merge. Review: GOOD TO GO (Sonnet) at |
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix — bug fixDescription
Closes #2294.
Integrity.rfcstested the whole registry cell againstUNKNOWN, but IANA spells the "no document" cell[UNSPECIFIED], brackets included — so it passed through unrendered, givingpcapkit.const.esp.integrityentries likeAUTH_DES_MAC [UNSPECIFIED] (DEPRECATED [:rfc:8247]).Cipher.rfcsshares the same check.UNKNOWNcomparison, in both crawlers. The const file is regenerated by running the crawler against the live registry;cipher.pyregenerates unchanged.test_esp_unspecified_reference_2294_unitchecks both crawlers'rfcshandling on bracketed and bare placeholders and renders the recorded registry into the committedintegrity.py.