Repository navigation
fix(interface): word reassembly, trace, output-format and engine-fallback messages in the house form (#2303) - #2374
Conversation
|
Review: NEEDS CHANGES at
Fix for 1/2/the docstring-tense nit in progress. |
…back messages in the house form (#2303) reassemble and trace raised "Unsupported ... protocol: foo", capitalised and without the value's repr; follow_tcp_stream warned "fallback to default engine" where Extractor says "using default engine instead", and left the engine's name unquoted when it has no reassembly adapter; TraceFlowBase.make_fout warned a capitalised "Unsupported output format: ..."; and Extractor.make_name raised "unknown output format: foo" with the value unquoted -- which, for an empty format, ends the message at the colon with nothing after it. Lowercase each message and quote the rejected value with !r, and use "using default engine instead" for every engine fallback. Test: tests/interface/test_message_form_2303_unit.py pins all seven messages.
737e19a to
f90b62a
Compare
|
Rebased and amended |
|
Review: GOOD TO GO at All findings across both rounds now addressed. |
|
Coverage: 91.58% (unit tier, Python 3.15,
Per-file detail: the |
|
Ready to merge. Review: GOOD TO GO (Sonnet, round 2) at |
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix — bug fixDescription
Closes #2303.
reassembleandtraceraised"Unsupported ... protocol: foo"— capitalised, and without the value's!r;follow_tcp_streamwarned"fallback to default engine"whereExtractorsays"using default engine instead", and left the engine's name unquoted in its own "no reassembly adapter" warning;TraceFlowBase.make_foutwarned a capitalised"Unsupported output format: ..."; andExtractor.make_nameraised"unknown output format: foo"with the value unquoted — for an empty format, that leaves nothing after the colon.!r, and use"using default engine instead"for every engine fallback.tests/interface/test_message_form_2303_unit.pypins all seven messages.