Skip to content

docs(ci): correct create-release's github job comment about the tag job (#2329) #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarryShaw merged 1 commit into from
Oct 27, 2026
+6 −3
Merged

docs(ci): correct create-release's github job comment about the tag job (#2329) #2379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,9 +446,12 @@ jobs:
# ``action.yml``), so no ``env:`` names one.
token: ${{ steps.app_token.outputs.token || secrets.GITHUB_TOKEN }}

# #1634: the same check ``tag``, ``pypi`` and ``conda`` make before they
# publish under this tag. Here it catches the tag having existed already
# at another commit, which ``action-gh-release`` silently reuses.
# #1634: the same check ``pypi`` and ``conda`` make before they publish
# under this tag. ``tag`` has no such step: its "Create Tag" makes the
# equivalent comparison inline, ``git rev-parse`` on the tags its own
# checkout fetched, without ``release_tags.resolve``'s fetch of the tag.
# Here the check catches the tag having existed already at another commit, which
# ``action-gh-release`` silently reuses.
- name: Check the release tags name this run's commit
env:
PCAPKIT_TAGS: v${{ needs.version_check.outputs.PCAPKIT_VERSION }}
Expand Down
Loading