Repository navigation
ci(deps): group github/codeql-action Dependabot bumps - #2390
Conversation
|
Review: NEEDS CHANGES at current head (Sonnet). The
Also surfaced, worth knowing: this grouping does NOT retroactively fix #2384-#2386 (Dependabot only reads config from |
|
Coverage: 91.58% (unit tier, Python 3.15,
Per-file detail: the |
9c1afb3 to
a9bd9eb
Compare
|
Amended: added |
|
Review: NEEDS CHANGES at
Fix in progress. |
…2386) Problem: Dependabot opened three separate PRs bumping one `github/codeql-action` step each (init, autobuild, analyze). codeql-action now refuses to run unless every step in the workflow is on the same version, so none of the three could pass CI alone -- init persists a configuration tagged with its own version, and the next step that runs at a different version refuses to read it: autobuild on two of the three, analyze on the third. Fix: group all `github/codeql-action/*` bumps under the github-actions ecosystem, so Dependabot opens one PR that bumps every step together. Test: tests/project/test_actions_pinned_1968.py's new TestDependabotGroupsTheCodeQLSteps checks the group sits under the right ecosystem and under no other, that its pattern claims every codeql-action step the workflows use and nothing else, and that those steps are pinned to one release. 7 of 8 mutations tried -- removing the group, a typo'd pattern, widening it to "*", repointing it, moving it under the wrong ecosystem, renaming it, and unpinning one step from the rest -- fail at least one of these tests; the full set is also exercised against a bare origin/main checkout.
a9bd9eb to
5024391
Compare
|
Amended All findings across both rounds now addressed. |
|
Review: GOOD TO GO at All findings across all 3 rounds now addressed. |
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci — workflows or build toolingDescription
github/codeql-actionstep each (autobuild,analyze,init).codeql-actionnow refuses to run unless every step in the workflow is on the same version, so none of the three can pass CI alone —initpersists a configuration tagged with its own version, and the next step that runs at a different version refuses to read it:Autobuildon build(deps): bump github/codeql-action/autobuild from 4.39.0 to 4.39.1 #2384/build(deps): bump github/codeql-action/init from 4.39.0 to 4.39.1 #2386,Perform CodeQL Analysison build(deps): bump github/codeql-action/analyze from 4.39.0 to 4.39.1 #2385 (Loaded a configuration file for version '4.39.0', but running version '4.39.1').github/codeql-action/*bumps under thegithub-actionsecosystem's Dependabot config, so future bumps land as one PR that updates every step together.tests/project/test_actions_pinned_1968.py's newTestDependabotGroupsTheCodeQLStepschecks the group sits under the right ecosystem and under no other, that its pattern claims every codeql-action step and nothing else, and that those steps are pinned to one release.