Repository navigation
fix(protocols): set NoPayload on terminal extension-header layers - #2488
Merged
Merged
Conversation
Owner
Author
|
NEEDS CHANGES (Sonnet,
|
- HOPOPT, IPv6_Opts, IPv6_Route, IPv6_Frag, HIP, MH and the generic IPv6_Ext fallback (Shim6) return early in extension mode, before _decode_next_layer sets _next. 'x' in such a layer then raised AttributeError. - Hold NoPayload on that path: the upper layer belongs to the enclosing IPv6 header. - Regression tests build the frames in memory, one per class.
JarryShaw
force-pushed
the
fix/2487-extension-header-membership
branch
from
October 31, 2026 03:39
7ceb5d5 to
abbc6ca
Compare
4 of 8 tasks
Contributor
|
Coverage: 94.50% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
GOOD TO GO (Sonnet, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2487
make pylint,make mypy,make isort)make testpasses, and a test case covers the changedocs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/AWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
HOPOPT, IPv6_Opts, IPv6_Route, IPv6_Frag, HIP, MH and the generic fallback (Shim6) return early in extension mode, before
_decode_next_layersets_next, so'x' in layerraisedAttributeError.These layers now hold
NoPayloadon that path. The upper layer belongs to the enclosing IPv6 header.Regression tests build frames in memory, including Shim6 in
test_ipv6_ext_unit.py. The Shim6 test fails on origin/main withAttributeError.test_ipv6_ext_unit.pyandtest_ah_unit.py: 45 passedexamples/generators/make_samples.pyrunsisort --check -l100 -p pcapkitclean on changed files