Repository navigation
refactor(application)!: move DRARP into its own module (#2529) - #2540
Merged
Merged
Conversation
A module holds one protocol class, named after it (owner ruling on #2529). BREAKING CHANGE: DRARP moves from pcapkit.protocols.application.rarp to pcapkit.protocols.application.drarp, and the old path keeps no re-export (#1715, #1744). pcapkit.DRARP and pcapkit.protocols.DRARP are unchanged. - rarp.py keeps RARP alone; RARP's dynamic DRARP alias is unchanged. - Docs: new drarp.rst, versionremoved:: 1.6.0 on rarp, refs retargeted; the VLAN, C/S-Tag and L2TP docs and tests drop the per-index rule. - Tests: the #1744 ledger takes a removal version; the reachability audit accepts a class inheriting its family base's __index__, not a shared module; new test_drarp_unit.py fails before the move.
Contributor
|
Coverage: 93.95% (unit tier, Python 3.15,
Per-file detail: the |
This was referenced Nov 1, 2026
JarryShaw
added
breaking
Owner
Author
|
Cross-review (Sonnet) at |
This was referenced Nov 1, 2026
Owner
Author
|
Re-ran Unit Tests (run 41289240031). Attempt 1 concluded success but never created the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 1, 2026
- Added: one's-complement checksum verification and computation (#2543), and the IPX and SCTP registration wrappers (#2521). - Folded into unreleased entries: LinuxSLL/FRAD/Netlink registries (#2527), the IGMP class names (#2542), TLS record chaining and the SSLv2 trial's warnings (#2537), DTLS reassembly via Extractor and toolkit (#2528), and IP_Pseudo's walk at any depth (#2543). ICMP drops its stale checksum line. - Breaking: make() checksums, DRARP's module (#2540), IPv6 overlapping fragments (#2569), TCP_GAP_LIMIT replacing TCP.__window__ (#2579), and Extractor/extract's positional dtls (#2528). - Changed: member order (#2490), conventions (#2542, #2521, #2570), CI -n logical (#2572). Fixed: AppType.get (#2568), trial warnings (#2519, #2577). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Part of #2529 (one protocol class per module, named after it).
DRARPmoves frompcapkit.protocols.application.rarptopcapkit.protocols.application.drarp, and the old path keeps no re-export (refactor(corekit)!: move the byte-order field helpers into corekit (#1711) #1715, refactor!: remove every surviving re-export of a moved name or module #1744).pcapkit.DRARPandpcapkit.protocols.DRARPare unchanged.rarp.pykeepsRARPalone, and RARP's dynamic DRARP alias is unchanged.drarp.rst,versionremoved:: 1.6.0on the old path, and references retargeted. The VLAN, C/S-Tag and L2TP docs drop the per-index rule.test_drarp_unit.pyfails before the move.