Repository navigation
docs(conventions): fix mint-criterion, process and layer-placement drift (#2549, #2550) - #2570
Merged
Merged
Conversation
…ift (#2549, #2550) - process.rst: move const out of the Type table into a note saying it is additive, as breaking is, with no const: commit prefix. - mint-criterion.rst: drop the "floor" hedge on the dead-code census, since Command, FEATCode and Method each reach _unregistered_member. - mint-criterion.rst: record AppType's real-service spans (x11, ircu, swx and the rest) as an exception to the code-suffix case, with the reason. - protocol-layer-placement.rst: rename the two finite-verb headings to "IANA Assignments: Encapsulation, Not Layer" and "Tunnelling Protocols: Payload, Not Carrier"; nothing else referenced them. test_conventions_doc_claims, the issue/PR role, comment-ref, internal-ref and project-status modules pass.
… without history (#2549, #2550) - mint-criterion.rst: the real-service-span note states only what is true now and names the transport registries, which hold the members, rather than AppType, which holds none. - CONTRIBUTING.md: drop const from the commit-type list and call it a label for regenerated constant tables, as process.rst does. - PULL_REQUEST_TEMPLATE.md: move const out of the commit-type boxes into its own "Also tick if" box. - test_conventions_doc_claims: re-pin const, which the move dropped from the template-to-page check, as a box outside the type list that process.rst says is not a type. test_conventions_doc_claims, the PR-template, docs role/ref and other CONTRIBUTING-reading modules pass.
JarryShaw
added
docs
Owner
Author
|
Cross-review (Sonnet) at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 93.94% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 1, 2026
- Added: one's-complement checksum verification and computation (#2543), and the IPX and SCTP registration wrappers (#2521). - Folded into unreleased entries: LinuxSLL/FRAD/Netlink registries (#2527), the IGMP class names (#2542), TLS record chaining and the SSLv2 trial's warnings (#2537), DTLS reassembly via Extractor and toolkit (#2528), and IP_Pseudo's walk at any depth (#2543). ICMP drops its stale checksum line. - Breaking: make() checksums, DRARP's module (#2540), IPv6 overlapping fragments (#2569), TCP_GAP_LIMIT replacing TCP.__window__ (#2579), and Extractor/extract's positional dtls (#2528). - Changed: member order (#2490), conventions (#2542, #2521, #2570), CI -n logical (#2572). Fixed: AppType.get (#2568), trial warnings (#2519, #2577). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseAlso tick if it regenerates constant or registry tables, members keeping their numeric values (the
constlabel)Description of your pull request and other information
Closes #2549, closes #2550.
constmoves out of the Type table into a note, because it is a label added alongside a type and no commit subject takes aconst:prefix. This also changes CONTRIBUTING.md's type list and the PR template, whereconstbecomes an "Also tick if" box outside the commit-type list, so all three agree.test_conventions_doc_claimspins the page against the template, and the chore(github): add a release commit-type box to the PR template #1102 test pins CONTRIBUTING's type list against the template.TCP(6001).name == 'x11') are recorded as the exception to code-suffixing (docs(conventions): AppType's real-service spans (x11, swx, ircu, ...) resolve with a bare label, which mint-criterion.rst says to code-suffix #2550). The stale "that list is a floor" hedge is dropped.