Skip to content

docs(pcapkit): give every undocumented shipped module a page - #2584

Merged
JarryShaw merged 2 commits into
mainfrom
docs/2559-module-pages
Nov 1, 2026
Merged

JarryShaw merged 2 commits into
mainfrom
docs/2559-module-pages

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • docs — documentation only

Description of your pull request and other information

This PR gives a documentation page to each shipped module that had none: pcapkit.const.linux, and the pcapkit.vendor.tls and pcapkit.vendor.sslv2 crawlers, among others. test_docs_module_pages_2559_unit fails on any undocumented module.

linux_sll.rst's "Hardware Types" now points to the const page instead of repeating ARPHRD's autoclass, so ARPHRD is documented once. A serial nitpicky build shows the 9 duplicate-object warnings gone. Against main it adds no warnings and clears 5 unresolved targets, and every ARPHRD link resolves to the const page.

Closes #2559

- Add const/linux.rst, vendor/tls.rst and vendor/sslv2.rst, mirroring
  vendor/linux.rst, const/tls.rst and const/sslv2.rst, and list them in
  the const and vendor toctrees.
- Retitle misc/checksum.rst "Checksums" and declare the three checksum
  packages under it, as pcap.rst does for the pcap packages; the IP
  pseudo-header and Internet checksum become its sections.
- const/tls.rst: both enumerations are generated by the TLS crawlers,
  no longer hand-curated.
- Add test_docs_module_pages_2559_unit.py, pinning documentation.rst's
  rule that every module outside NotImplemented/ has a directive, and
  cite it there.

Docs tests and a nitpicky partial build of the touched pages pass.
- linux_sll.rst's "Hardware Types" autoclass rendered
  pcapkit.const.linux.arphrd.ARPHRD a second time now that
  const/linux.rst documents it, so a serial nitpicky build reported
  duplicate object descriptions. The section now points to the const
  page, the single home every other const registry has.

Docs tests pass; a serial nitpicky build has no duplicate warnings.
@JarryShaw JarryShaw added docs Pull requests that change documentation only (docs: subject prefix) review: good-to-go Cross-review at the current head says ready; CI state is separate labels Nov 1, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at f7232f6a8. The Sonnet review and its delta both pass.

@JarryShaw JarryShaw moved this to In review in PyPCAPKit Nov 1, 2026
@JarryShaw
JarryShaw merged commit 0b25f04 into main Nov 1, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Nov 1, 2026
@JarryShaw
JarryShaw deleted the docs/2559-module-pages branch November 1, 2026 18:51
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Nov 1, 2026
JarryShaw added a commit that referenced this pull request Nov 1, 2026
…ons into 1.6.0 (#2449)

- Breaking: HTTP dispatches to HTTPv1/HTTPv2 on read, make and from_data,
  and so does a transport payload, whose data key moves from http to
  httpv1/httpv2; the members and their schema and data classes are renamed
  from httpv1.HTTP/httpv2.HTTP with no re-export; id() takes the RFC names;
  unrecognised transport payloads are Raw with no error (#2544).
- Changed: conventions record the dispatching base (#2544) and the
  case-fold exceptions (#2583); a project test guards every shipped
  module's documentation entry (#2584). Summary names the HTTP change.
- CHANGELOG.md regenerated; util/changelog_md.py --check passes.
@github-actions github-actions Bot added this to the PyPCAPKit v1.6 milestone Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

docs: shipped modules with no documentation page (const.linux, vendor.tls, vendor.sslv2 and the checksum packages)

1 participant