Repository navigation
fix(const): re-export the Linux ARPHRD registry as Linux_ARPHRD (#2661) - #2663
Merged
Merged
Conversation
- pcapkit.const.linux exported ARPHRD unprefixed, where every other package prefixes its registries and pcapkit.vendor.linux exports Linux_ARPHRD. Re-export it as Linux_ARPHRD and list that in __all__. - pcapkit.const star-imported no Linux package, so the registry was missing from pcapkit.const.__all__. Import it and list it. - Name Linux_ARPHRD on the linux docs page, and drop the linux entry from KNOWN_UNWIRED in test_const_package_exports_2656_unit. - Add test_const_linux_export_2661_unit for the runtime surface. No caller imported the unprefixed name, and it is in no release tag, so no alias or versionchanged is kept.
JarryShaw
added
fix
Owner
Author
|
GOOD TO GO at |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…he cut-frame fixes and GRE's bindings into 1.6.0 (#2449) - Breaking: TCP, UDP and SCTP makers (#2670) and PCAP-NG's (#2671) raise on a value a field cannot hold, where 1.5.x wrote it masked; each entry gives the old and new values. The TTL Diff wraps as before. - Changed: __index__ returns the LinkType, EtherType, TransType or AppType value, ports as ints (#2652); only Create Release waits for a deployment approval (#2658). The conventions entry records the index rule. - Fixed: a cut HTTP/2 SETTINGS frame parses and rebuilds; HTTPv2.make takes frame_length (#2666). - Folded into unreleased entries: FRAD at LinkType 107 and GRE at IP protocol 47 (#2667); cut IGMPv3 messages and num_group_records (#2662, #2672); Linux_ARPHRD (#2663); DCCP's range checks (#2670); a cut GRE frame is TRUNCATED, replacing fold-12's INVALID note, and frame_length in pcapkit.utilities.contextvars (#2668). - No entry for _make_sint's private allow_unsigned, ARP's private PAT_MAC_ADDR, or the test- and docs-only d728873, 326a6cf, fc80fb1, a37edf1 and 2766707. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— fixes a bugDescription of your pull request and other information
pcapkit.constre-exports the Linux ARPHRD registry. It is the one const subpackagepcapkit/const/__init__.pydid not star-import, and #2656's guard records it as a known gap.pcapkit.const.linuxexports it asLinux_ARPHRD, the house prefix thatpcapkit.vendor.linuxalready uses. The name is in no release, so the rename breaks nothing that shipped.pcapkit/const/__init__.pystar-imports it, and the docs page uses the new name.KNOWN_UNWIREDentry intest_const_package_exports_2656_unitcomes out, and a new test pins the export.No caller imported the name from the package; every one imports from
pcapkit.const.linux.arphrd, which is unchanged. I reviewed the diff (the worker ran on Sonnet). With thepcapkit/change reverted, the new test and the #2656 guard both fail.Closes #2661