Repository navigation
Conversation
Signed-off-by: pratyu2h <pratyush07sharma@gmail.com>
Owner
|
Thanks for picking this up. NEEDS CHANGES, and it overlaps with #2736, which was opened earlier for #2733 and has been reviewed.
Which PR to take is the maintainer's call. |
Author
|
Thank you for the detailed review and guidance @JarryShaw! Closing this PR in favor of #2736. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
What is the purpose of your pull request?
Description of your pull request and other information
Resolves #2733.
When dumping an Info or subclass instance via ields(), keys that clash with builtin names are assigned to map and their original name is appended to builtin and excluded. Previously, ields() directly checked if key not in skip, which caused keys like 'items' on Info or 'packet' on a reassembled TCP Datagram to be dropped from the dump despite being explicitly defined.
This PR checks keymap.get(key, key) not in skip where keymap = getattr(info, 'map', {}). This ensures renamed builtin keys are kept in the dumped output under their original name while still excluding regular excluded attributes. Added unit test in ests/dumpkit/test_common_unit.py.