Repository navigation
refactor(utilities): rename utilities.lazy to utilities.importlib (#2747) - #2748
Merged
Merged
Conversation
) The owner asked to rename the module holding `lazy_exports`. `importlib` follows the stdlib-domain naming `pcapkit.utilities.pickle` set (#2722); `imp` was passed over as the name of the stdlib module Python 3.12 removed. `lazy_exports` keeps its name. Every `pcapkit.const` package imports it from the new path, and the API page (renamed with its toctree entry), the const-vendor pairing convention and the tests follow. The old path never shipped, so it gets no re-export, no shim and no deprecation note. The module's own `import importlib` is absolute, so it still binds the standard library module, and `sys.modules['importlib']` is unchanged after `import pcapkit`.
JarryShaw
added
refactor
1 of 5 tasks
Owner
Author
|
GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 94.44% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 3, 2026
- Fixed: a layer rebuilt by from_data reports its payload's messages once, where 1.5.x logged them twice, and IPv4 and the frame-end layers record a cut as their own short read (#2738), a new entry; old values measured against v1.5.1. - Folded into unreleased entries (#2738): a standalone IGMPv3 Report sized by its record count, into the IGMP entry; the recorded cuts' TRUNCATED status, TSO IPv4 and ICMPv4 included, into the checksum entry; ListField's count, into its zero-fill entry; the quiet rebuilt payload, into the conventions entry. - #2748: pcapkit.utilities.lazy becomes pcapkit.utilities.importlib in the lazy-import and conventions entries; the old name appears nowhere. - No entry for the direct-pushed 21ec0a6, which has no pull request or issue to cite. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
Renames
pcapkit.utilities.lazytopcapkit.utilities.importlib, as the owner asked, following thepcapkit.utilities.pickleprecedent.lazy_exportskeeps its name.git mvof the module and of its docs page. Every import in thepcapkit.constpackages, the utilities index and toctree,const-vendor-pairing.rstand the tests now use the new path.pcapkit.utilities.lazyno longer imports.import pcapkit,sys.modules['importlib']is still the stdlib module, and that is what the new module's ownimport importlibbinds.Closes #2747