Skip to content

Commit 75902b8

Browse files
authored
feat: honor/preserve user's option order (#1106)
* options should preserve creation order * remove noise * remove extra lines
1 parent 73e801c commit 75902b8

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

common-tools/clas-utils/src/main/java/org/jlab/utils/options/OptionParser.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import java.util.Map;
88
import java.util.Properties;
99
import java.util.Set;
10-
import java.util.TreeMap;
10+
import java.util.LinkedHashMap;
1111
import java.util.logging.Logger;
1212
import java.util.logging.Level;
1313
import org.jlab.logging.SplitLogManager;
@@ -19,9 +19,9 @@
1919
*/
2020
public class OptionParser {
2121

22-
private Map<String,OptionValue> optionsDescriptors = new TreeMap<>();
23-
private Map<String,OptionValue> requiredOptions = new TreeMap<>();
24-
private Map<String,OptionValue> parsedOptions = new TreeMap<>();
22+
private Map<String,OptionValue> optionsDescriptors = new LinkedHashMap<>();
23+
private Map<String,OptionValue> requiredOptions = new LinkedHashMap<>();
24+
private Map<String,OptionValue> parsedOptions = new LinkedHashMap<>();
2525
private Set<String> overridenOptions = new HashSet<>();
2626
private List<String> parsedInputList = new ArrayList<>();
2727
private String program = "undefined";
@@ -129,13 +129,7 @@ public String getUsageString(){
129129
}
130130

131131
public void printUsage(){
132-
System.out.println("\n\n");
133-
System.out.println("*******************************************");
134-
System.out.println("* PROGRAM USAGE : by OptionParser *");
135-
System.out.println("*******************************************");
136-
System.out.println("\n\n");
137132
System.out.println(this.getUsageString());
138-
System.out.println("\n\n");
139133
}
140134

141135
public void parse(String... args) {

0 commit comments

Comments
 (0)