Commit 9223156
Consume jnp-hipo4 4.5 from the hipo-java package registry (#1360)
* build: consume jnp-hipo4 4.5 from the hipo-java package registry
jnp-hipo4 is now built and released from its own repository,
code.jlab.org/hallb/clas12/hipo-java, instead of being cut from the monolithic
jnp tree. Points the dependency at 4.5 from that project's package registry,
which is public and needs no credentials.
Two things this changes beyond the coordinate. The old clasweb artifact was a fat
jar bundling exp4j, lz4 and xxhash, so the exp4j 0.4.8 pinned here to resolve the
jnp-hipo/jnp-hipo4 conflict was being shadowed by a bundled copy; 4.5 publishes a
plain jar and declares exp4j and lz4-java as ordinary dependencies, so that pin
governs again. It also drops the classes the fat jar duplicated with jnp-hipo
(matrix, ascii, readers, MigLayout) -- all still supplied by jnp-hipo, which this
project already depends on, and the ones this project actually imports come from
there.
Verified against an unmodified development baseline: 49 modules build, 1620
source files compile, and the test suite is identical -- 14 run, 0 failures, and
the same single DCReconstructionTest error, which is the absent TORUS field map
and reproduces without this change. maven-enforcer's DependencyConvergence passes.
* build: list the hipo-java repository first, per review
Maven queries repositories in declaration order and takes the first that
answers with the coordinate, so whichever comes first *decides* what
`org.jlab.jnp:jnp-hipo4` resolves to. The clasweb repositories still carry the
old fat-jar `jnp-hipo4`; with them ahead of this entry, either one serving a
4.5 would shadow the artifact this project means to consume, and nothing would
report it.
Verified rather than assumed. The effective POM now orders them
clas12-hipo-java, clas12maven, jnp-maven, central. With the local cache entry
removed, `jnp-hipo4:4.5` is downloaded from clas12-hipo-java.
The trade-off is real and is written into the comment: code.jlab.org is asked
first for every artifact and misses on all but `jnp-hipo4`. Resolving
`org.json:json` walks clas12-hipo-java, clas12maven, jnp-maven, then central,
which serves it. Note the miss is silent at default verbosity — Maven logs no
404, it just tries the next repository — so the cost is latency and a stall
when that host is unwell, not visible errors. It goes away if a real repository
manager ever proxies these.
* Clean up pom.xml by removing comments
Removed lengthy comments about repository configuration and updated the repository entry for `clas12-hipo-java`.
* Clean up comment syntax in pom.xml
Removed unnecessary comment syntax from pom.xml.
---------
Co-authored-by: Nathan Baltzell <baltzell@gmx.com>1 parent b6ca546 commit 9223156
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
22 | 26 | | |
23 | 27 | | |
24 | 28 | | |
| |||
168 | 172 | | |
169 | 173 | | |
170 | 174 | | |
171 | | - | |
| 175 | + | |
172 | 176 | | |
173 | 177 | | |
174 | 178 | | |
| |||
216 | 220 | | |
217 | 221 | | |
218 | 222 | | |
219 | | - | |
| 223 | + | |
220 | 224 | | |
221 | 225 | | |
222 | 226 | | |
| |||
0 commit comments