fix: better curl

Author: c-dilks

.github/workflows/orca.yml

@@ -22,14 +22,15 @@ jobs:
       - name: trigger orca pipeline
         id: trigger
         run: |
-          response=$(curl -X POST \
-            -F "token=${{ secrets.ORCA_TRIGGER_TOKEN }}" \
-            -F "ref=main" \
-            -F "variables[TRIGGERED_BY]=github" \
-            -F "variables[GITHUB_REPO]=${{ github.repository }}" \
-            -F "variables[GITHUB_SHA]=${{ github.sha }}" \
-            -F "variables[GITHUB_RUN_ID]=${{ github.run_id }}" \
-            -F "variables[REF_COATJAVA]=${{ github.head_ref || github.ref_name }}" \
+          response=$(curl \
+            --request POST \
+            --form "token=${{ secrets.ORCA_TRIGGER_TOKEN }}" \
+            --form "ref=main" \
+            --form "variables[TRIGGERED_BY]=github" \
+            --form "variables[GITHUB_REPO]=${{ github.repository }}" \
+            --form "variables[GITHUB_SHA]=${{ github.sha }}" \
+            --form "variables[GITHUB_RUN_ID]=${{ github.run_id }}" \
+            --form "variables[REF_COATJAVA]=${{ github.head_ref || github.ref_name }}" \
             "https://code.jlab.org/api/v4/projects/${{ secrets.ORCA_PROJECT_ID }}/trigger/pipeline")
           echo "RESPONSE: $response"
           pipeline_id=$(echo $response | jq -r '.id')
@@ -45,7 +46,6 @@ jobs:
           echo "Pipeline URL: <$web_url>" >> $GITHUB_STEP_SUMMARY
       - name: wait for orca pipeline
         env:
-          GITLAB_TOKEN: ${{ secrets.ORCA_READ_TOKEN }}
           PIPELINE_ID: ${{ steps.trigger.outputs.pipeline_id }}
           PIPELINE_URL: ${{ steps.trigger.outputs.web_url }}
           TIMEOUT: 3600
@@ -54,9 +54,13 @@ jobs:
           elapsed=0
           sleep_interval=60
           while [ $elapsed -lt $TIMEOUT ]; do
-            status=$(curl -s -H "PRIVATE-TOKEN: $GITLAB_TOKEN" \
-              "https://gitlab.com/api/v4/projects/${{ secrets.ORCA_PROJECT_ID }}/pipelines/$PIPELINE_ID" \
-              | jq -r '.status')
+            response=$(curl \
+              --silent \
+              --show-error \
+              --fail \
+              --header "PRIVATE-TOKEN: ${{ secrets.ORCA_READ_TOKEN }}" \
+              "https://gitlab.com/api/v4/projects/${{ secrets.ORCA_PROJECT_ID }}/pipelines/$PIPELINE_ID")
+            status=$(echo $response | jq -r '.status')
             echo "Current status: $status (elapsed: ${elapsed}s)"
             case $status in
               "success")