use the same time2distance for simu and real data - #935
Merged
Merged
Conversation
ftouchte
requested review from
N-Plx,
baltzell,
efuchey,
mathieuouillon,
mpaolone and
whit2333
as code owners
November 4, 2025 16:23
baltzell
approved these changes
Nov 4, 2025
Collaborator
|
We'd like to have a new COATJAVA release this week. Would it be best to wait to merge this until the corresponding changes are released in GEMC/5.12? I think that is next week. On the other hand, if this isn't really breaking much, e.g., if there's already significant GEMC/COATJAVA inconsistencies for AHDC, maybe this PR can/should go ahead and be merged? |
Collaborator
Author
|
This PR can wait the next GEMC release as it has no effect on real data. |
baltzell
force-pushed
the
feat/t2d-gemc
branch
from
November 13, 2025 03:11
5790f8e to
808d95c
Compare
Collaborator
Author
|
A new release of GEMC is available. I think we can push this commit. |
Collaborator
|
It doesn't appear to be fully available yet, but I guess we should go ahead? |
baltzell
force-pushed
the
feat/t2d-gemc
branch
from
November 22, 2025 00:27
808d95c to
4a1e602
Compare
baltzell
self-requested a review
November 22, 2025 00:27
baltzell
approved these changes
Nov 22, 2025
baltzell
force-pushed
the
feat/t2d-gemc
branch
from
November 22, 2025 03:51
4a1e602 to
b03bdd7
Compare
baltzell
force-pushed
the
feat/t2d-gemc
branch
from
December 1, 2025 02:06
b03bdd7 to
824e133
Compare
We now invert the ccdb time2distance in simulation.
baltzell
force-pushed
the
feat/t2d-gemc
branch
from
December 4, 2025 15:51
824e133 to
f537bbc
Compare
baltzell
enabled auto-merge (squash)
December 4, 2025 15:51
tongtongcao
pushed a commit
that referenced
this pull request
Dec 12, 2025
We now invert the ccdb time2distance in simulation.
tongtongcao
pushed a commit
that referenced
this pull request
Dec 12, 2025
We now invert the ccdb time2distance in simulation.
tongtongcao
pushed a commit
that referenced
this pull request
Dec 31, 2025
We now invert the ccdb time2distance in simulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now invert the ccdb time2distance in simulation.
gemc/clas12Tags#58