Skip to content

Commit b917c09

Browse files
authored
Fix/list translations (#394)
<img width="532" height="41" alt="image" src="https://github.com/user-attachments/assets/ca938ef5-cac7-41d6-9f93-16052b3d591b" /> turns out server side translations aren't loaded yet when registering commands
1 parent 0ce6cf1 commit b917c09

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ org.gradle.jvmargs=-Xmx2048M
33

44
# Fabric Properties
55
# check these on https://fabricmc.net/develop
6-
minecraft_version=26.2-rc-2
6+
minecraft_version=26.2
77
loader_version=0.18.3
88
loom_version=1.17-SNAPSHOT
99

src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public static void register(
168168
homeListBuilder
169169
.requires(ECPerms.require(ECPerms.Registry.home_tp, 0))
170170
.executes(ListCommandFactory.create(
171-
ECText.getInstance().getString("cmd.home.list.start"),
171+
"cmd.home.list.start",
172172
"home tp",
173173
HomeCommand.Suggestion::getSuggestionEntries));
174174

@@ -255,7 +255,7 @@ public static void register(
255255
warpListBuilder
256256
.requires(ECPerms.require(ECPerms.Registry.warp_tp, 0))
257257
.executes(ListCommandFactory.create(
258-
ECText.getInstance().getString("cmd.warp.list.start"),
258+
"cmd.warp.list.start",
259259
"warp tp",
260260
(context) -> ManagerLocator.getInstance().getWorldDataManager().getAccessibleWarps(context.getSource().getPlayerOrException()).toList(),
261261
NamedMinecraftLocation::getName

src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,12 @@ private ListCommandFactory() {}
2929

3030
// Specify leading response text, and supplier of list of strings/Text
3131
public static <T> Command<CommandSourceStack> create(
32-
String responsePreText,
32+
String translationKey,
3333
String commandExecText,
3434
SuggestionListProvider<Entry<String, T>> suggestionsProvider)
3535
{
3636
return (CommandContext<CommandSourceStack> context) -> {
37+
String responsePreText = ECText.getInstance().getString(translationKey);
3738
var styleProvider = PlayerProfile.accessFromContextOrThrow(context);
3839
Collection<Entry<String, T>> suggestionsList = suggestionsProvider.getSuggestionList(context);
3940

@@ -46,12 +47,13 @@ public static <T> Command<CommandSourceStack> create(
4647
}
4748

4849
public static <T> Command<CommandSourceStack> create(
49-
String responsePreText,
50+
String translationKey,
5051
String commandExecText,
5152
SuggestionListProvider<T> suggestionsProvider,
5253
Function<T, String> nameAccessor)
5354
{
5455
return (CommandContext<CommandSourceStack> context) -> {
56+
String responsePreText = ECText.getInstance().getString(translationKey);
5557
var styleProvider = PlayerProfile.accessFromContextOrThrow(context);
5658
Collection<T> suggestionsList = suggestionsProvider.getSuggestionList(context);
5759

0 commit comments

Comments
 (0)