Sync to upstream Luau 0.733 (#1578)

Author: luau-language-server-helper[bot]

CHANGELOG.md

@@ -12,7 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Changed
 
-- Sync to upstream Luau 0.731
+- Sync to upstream Luau 0.733
 
 ## [1.69.0] - 2026-07-14
 

luau

@@ -4,6 +4,8 @@
 #include "Luau/ConstraintSolver.h"
 #include "Luau/TypeInfer.h"
 
+LUAU_FASTFLAG(LuauCyclicRequireTypeInference)
+
 // Parse class names from QueryDescendants CSS-like selector strings.
 // Returns the class name from the last compound selector of each comma-separated group.
 std::vector<std::string> parseClassNamesFromSelector(const std::string& selector)
@@ -136,8 +138,14 @@ bool MagicInstanceIsA::infer(const Luau::MagicFunctionCallContext& context)
     std::string className(str->value.data, str->value.size);
     std::optional<Luau::TypeFun> tfun = context.solver->rootScope->lookupType(className);
     if (!tfun)
-        context.solver->reportError(
-            Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}});
+    {
+        if (FFlag::LuauCyclicRequireTypeInference)
+            context.solver->reportError(
+                Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, context.callSite->args.data[0]->location, *context.constraint->moduleName);
+        else
+            context.solver->DEPRECATED_reportError(
+                Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}});
+    }
 
     return false;
 }
@@ -280,7 +288,10 @@ bool MagicInstanceFindFirstXWhichIsA::infer(const Luau::MagicFunctionCallContext
     std::optional<Luau::TypeFun> tfun = context.solver->rootScope->lookupType(className);
     if (!tfun || !tfun->typeParams.empty() || !tfun->typePackParams.empty())
     {
-        context.solver->reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, str->location);
+        if (FFlag::LuauCyclicRequireTypeInference)
+            context.solver->reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, str->location, *context.constraint->moduleName);
+        else
+            context.solver->DEPRECATED_reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, str->location);
         return false;
     }
 
@@ -344,8 +355,14 @@ bool MagicEnumItemIsA::infer(const Luau::MagicFunctionCallContext& context)
     std::string enumItem(str->value.data, str->value.size);
     std::optional<Luau::TypeFun> tfun = context.constraint->scope->lookupImportedType("Enum", enumItem);
     if (!tfun)
-        context.solver->reportError(
-            Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownSymbol{enumItem, Luau::UnknownSymbol::Type}});
+    {
+        if (FFlag::LuauCyclicRequireTypeInference)
+            context.solver->reportError(
+                Luau::UnknownSymbol{enumItem, Luau::UnknownSymbol::Type}, context.callSite->args.data[0]->location, *context.constraint->moduleName);
+        else
+            context.solver->DEPRECATED_reportError(
+                Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownSymbol{enumItem, Luau::UnknownSymbol::Type}});
+    }
 
     return false;
 }
@@ -433,7 +450,11 @@ bool MagicInstancePropertyCheck::infer(const Luau::MagicFunctionCallContext& con
     std::string property(str->value.data, str->value.size);
     if (!Luau::lookupExternTypeProp(ctv, property))
     {
-        context.solver->reportError(Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownProperty{*selfTy, property}});
+        if (FFlag::LuauCyclicRequireTypeInference)
+            context.solver->reportError(
+                Luau::UnknownProperty{*selfTy, property}, context.callSite->args.data[0]->location, *context.constraint->moduleName);
+        else
+            context.solver->DEPRECATED_reportError(Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownProperty{*selfTy, property}});
     }
 
     return false;
@@ -513,7 +534,10 @@ bool MagicQueryDescendants::infer(const Luau::MagicFunctionCallContext& context)
         std::optional<Luau::TypeFun> tfun = context.solver->rootScope->lookupType(className);
         if (!tfun || !tfun->typeParams.empty() || !tfun->typePackParams.empty())
         {
-            context.solver->reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, str->location);
+            if (FFlag::LuauCyclicRequireTypeInference)
+                context.solver->reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, str->location, *context.constraint->moduleName);
+            else
+                context.solver->DEPRECATED_reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, str->location);
             return false;
         }
         classTypes.push_back(Luau::follow(tfun->type));
@@ -619,8 +643,12 @@ bool MagicTypeLookup::infer(const Luau::MagicFunctionCallContext& context)
             std::optional<Luau::TypeFun> tfun = context.solver->rootScope->lookupType(className);
             if (!tfun || !tfun->typeParams.empty() || !tfun->typePackParams.empty())
             {
-                context.solver->reportError(
-                    Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}});
+                if (FFlag::LuauCyclicRequireTypeInference)
+                    context.solver->reportError(Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}, context.callSite->args.data[0]->location,
+                        *context.constraint->moduleName);
+                else
+                    context.solver->DEPRECATED_reportError(
+                        Luau::TypeError{context.callSite->args.data[0]->location, Luau::UnknownSymbol{className, Luau::UnknownSymbol::Type}});
                 return false;
             }
 
@@ -631,8 +659,12 @@ bool MagicTypeLookup::infer(const Luau::MagicFunctionCallContext& context)
         }
         else
         {
-            context.solver->reportError(
-                Luau::TypeError{context.callSite->args.data[0]->location, Luau::GenericError{errorMessagePrefix + " '" + className + "'"}});
+            if (FFlag::LuauCyclicRequireTypeInference)
+                context.solver->reportError(Luau::GenericError{errorMessagePrefix + " '" + className + "'"},
+                    context.callSite->args.data[0]->location, *context.constraint->moduleName);
+            else
+                context.solver->DEPRECATED_reportError(
+                    Luau::TypeError{context.callSite->args.data[0]->location, Luau::GenericError{errorMessagePrefix + " '" + className + "'"}});
         }
     }