Repository navigation
CompatHelper: bump compat for MatrixPencils to 2, (keep existing compat) - #161
Merged
baggepinnen merged 2 commits intoNov 11, 2026
Conversation
baggepinnen
force-pushed
the
compathelper/new_version/2026-11-11-04-23-13-910-03587401368
branch
from
November 11, 2026 04:23
d9ccc79 to
945440d
Compare
MatrixPencils v2 requires MatrixEquations v3 and MatrixPencils v1 restricts MatrixEquations to v2, so the two compat bounds must be raised together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Combined with the MatrixEquations v3 bump from #162, since MatrixPencils v2 requires MatrixEquations v3. CI cannot resolve these versions because LinearMPC (a test dependency) restricts MatrixEquations to v2. The test suite was run locally on Julia 1.10 with MatrixEquations v3.0.0, MatrixPencils v2.0.0 and ControlSystemsBase v1.25.4, with LinearMPC removed from the test target: 1552 passed, 6 broken, and the only error is the LinearMPC example that cannot load without LinearMPC. |
baggepinnen
deleted the
compathelper/new_version/2026-11-11-04-23-13-910-03587401368
branch
November 11, 2026 10:56
baggepinnen
referenced
this pull request
Nov 11, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
MatrixPencilspackage from1to1, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.