Skip to content

ObjectiveC: Don't add 'immutable' flag. #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maleadt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ObjectiveC: Don't add 'immutable' flag. #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/generator/codegen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ end
end

# @objcwrapper
wrapperexpr = Expr(:macrocall, Symbol("@objcwrapper"), nothing, Expr(:(=), :immutable, :true))
wrapperexpr = Expr(:macrocall, Symbol("@objcwrapper"), nothing)

# add availability attribute before type declaration
if !isnothing(platform_availability) && !isnothing(minsupported) && convert(VersionNumber, platform_availability.Introduced) > minsupported
Expand Down
8 changes: 4 additions & 4 deletions test/generators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,11 @@ end
end

print(output[])
@test contains(output[],"@objcwrapper immutable = true TestProtocol <: NSObject") # Protocol
@test contains(output[],"@objcwrapper immutable = true TestProtocol2 <: TestProtocol") # Protocol subtyping Protocol
@test contains(output[],"@objcwrapper immutable = true TestInterface <: NSObject") # Interface
@test contains(output[],"@objcwrapper TestProtocol <: NSObject") # Protocol
@test contains(output[],"@objcwrapper TestProtocol2 <: TestProtocol") # Protocol subtyping Protocol
@test contains(output[],"@objcwrapper TestInterface <: NSObject") # Interface

@test contains(output[],"@objcwrapper immutable = true availability = macos(v\"100.11.0\") TestAvailability <: NSObject") # Wrapper Availability
@test contains(output[],"@objcwrapper availability = macos(v\"100.11.0\") TestAvailability <: NSObject") # Wrapper Availability
@test contains(output[],"@autoproperty length::Int32 availability = macos(v\"101.11.0\")") # Property Availability

# Interface Properties
Expand Down
Loading