Repository navigation
Adopt the new development workflow - #29
Merged
Merged
Conversation
* Standard Makefile: test and coverage with only the `test` environment on the LOAD_PATH, coverage and formatter in temporary environments, stacked development REPL, no devrepl.jl * Reduce test/Project.toml to what the tests use, and reference the package itself via [sources] * New CI: sibling [sources] warnings, held-back dependency check, a lowest-compat job on the oldest supported Julia, and the [sources] lint in the codestyle job * Move the downstream GRAPE tests from CI.yml into their own workflow, testing GRAPE's master branch against the current QuantumGradientGenerators
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
========================================
- Coverage 88.1% 86.4% -1.7%
========================================
Files 6 6
Lines 302 301 -1
========================================
- Hits 266 260 -6
- Misses 36 41 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the package to the organization-wide development workflow (https://github.com/JuliaQuantumControl/.github/blob/master/CONTRIBUTING.md#development-workflow). No user-facing changes.
The new "Test GRAPE" workflow will fail until GRAPE's own workflow PR is merged: GRAPE's master branch still uses
QuantumControlTestUtils.DummyOptimization, which no longer exists in QuantumControlTestUtils 0.4.0. That job is informational (continue-on-error).