Support for multihost and status for alerts - #76
Open
Vity01 wants to merge 1 commit into
Open
Conversation
|
@Vity01 This is great. Do you have any advice on how this can be approached without manually defining Grafanas in |
Author
|
@dtemir I don't think it is a good idea. Think about secrets, proxies... |
|
@Vity01 Any updates on this PR? |
higor-duarte-oliveira
approved these changes
Apr 22, 2024
2 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I present my solution for multihost Grafanas. It's easy to use and the code should be backwards compatible with current implementation. Use can choose whether to use multihost setting or a simple one.
Example of usage:
I also integrated support for getting status for Alerts (sorry I had to mix it, it would be a mess to separate it).
#65 and #70