script add improvement

Author: ukumar-ks

KeeperSdk/src/pam/rotation/addRotationScript.ts

@@ -1,6 +1,14 @@
+import * as fs from 'fs'
 import * as path from 'path'
 import type { Auth, DRecord } from '@keeper-security/keeperapi'
-import { generateUid } from '@keeper-security/keeperapi'
+import {
+    fileAddMessage,
+    generateEncryptionKey,
+    generateUid,
+    normal64Bytes,
+    platform,
+    Records,
+} from '@keeper-security/keeperapi'
 import type { InMemoryStorage } from '../../storage/InMemoryStorage'
 import { VaultObjectKind } from '../../folders/folderHelpers'
 import { getRecordType } from '../../records/RecordUtils'
@@ -36,7 +44,57 @@ export async function addRotationScript(
         const dataFields = recordData.fields
         const fileName = path.basename(expandedPath)
 
+        const recordKey = await storage.getKeyBytes(record.uid)
+        if (!recordKey) {
+            throw new KeeperSdkError(
+                `Unable to retrieve encryption key for record "${record.uid}"`,
+                ResultCodes.PAM_CONFIG_CREATE_FAILED
+            )
+        }
+
         const fileUid = generateUid()
+        const fileKey = generateEncryptionKey()
+        const scriptData = new Uint8Array(fs.readFileSync(expandedPath))
+        const encryptedScript = await platform.aesGcmEncrypt(scriptData, fileKey)
+        const fileMetadata = platform.stringToBytes(
+            JSON.stringify({
+                title: fileName,
+                name: fileName,
+                type: 'application/octet-stream',
+                size: scriptData.length,
+            })
+        )
+
+        const filesAddResponse = await auth.executeRest(
+            fileAddMessage({
+                clientTime: Date.now(),
+                files: [
+                    {
+                        recordUid: normal64Bytes(fileUid),
+                        recordKey: await platform.aesGcmEncrypt(fileKey, auth.dataKey!),
+                        data: await platform.aesGcmEncrypt(fileMetadata, fileKey),
+                        fileSize: encryptedScript.length,
+                        isScript: true,
+                    },
+                ],
+            })
+        )
+        const fileStatus = filesAddResponse.files?.[0]
+        if (!fileStatus || fileStatus.status !== Records.FileAddResult.FA_SUCCESS || !fileStatus.url) {
+            throw new KeeperSdkError('Failed to obtain script file upload URL', ResultCodes.PAM_CONFIG_CREATE_FAILED)
+        }
+
+        let uploadParameters: { [key: string]: string }
+        try {
+            uploadParameters = JSON.parse(fileStatus.parameters || '{}')
+        } catch {
+            throw new KeeperSdkError('Invalid script file upload parameters', ResultCodes.PAM_CONFIG_CREATE_FAILED)
+        }
+        const uploadResponse = await platform.fileUpload(fileStatus.url, uploadParameters, encryptedScript)
+        if (fileStatus.successStatusCode && uploadResponse?.statusCode !== fileStatus.successStatusCode) {
+            throw new KeeperSdkError('Failed to upload script file', ResultCodes.PAM_CONFIG_CREATE_FAILED)
+        }
+
         const scriptValue: RotationScriptValue = {
             fileRef: fileUid,
             recordRef: [],
@@ -54,17 +112,30 @@ export async function addRotationScript(
             }
         }
 
-        const newScriptField = {
-            type: SCRIPT_FIELD_TYPE,
-            label: SCRIPT_FIELD_LABEL,
-            value: [scriptValue],
+        const scriptField = dataFields.find(
+            (field) => field.type === SCRIPT_FIELD_TYPE && Array.isArray(field.value)
+        )
+        if (scriptField) {
+            scriptField.label = SCRIPT_FIELD_LABEL
+            scriptField.required = false
+            scriptField.value.push(scriptValue)
+        } else {
+            dataFields.push({
+                type: SCRIPT_FIELD_TYPE,
+                label: SCRIPT_FIELD_LABEL,
+                value: [scriptValue],
+                required: false,
+            })
         }
-
-        dataFields.push(newScriptField)
         recordData.fields = dataFields
         record.data = recordData
 
-        await updatePamRecordFields(auth, record, recordType, dataFields, currentRevision, storage)
+        await updatePamRecordFields(auth, record, recordType, dataFields, currentRevision, storage, [
+            {
+                recordUid: normal64Bytes(fileUid),
+                recordKey: await platform.aesGcmEncrypt(fileKey, recordKey),
+            },
+        ])
 
         return {
             success: true,

KeeperSdk/src/pam/rotation/rotationScriptHelpers.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs'
 import * as path from 'path'
-import type { Auth, DRecord } from '@keeper-security/keeperapi'
+import type { Auth, DRecord, Records } from '@keeper-security/keeperapi'
 import type { InMemoryStorage } from '../../storage/InMemoryStorage'
 import { VaultObjectKind } from '../../folders/folderHelpers'
 import { getRecordTitle, getRecordType } from '../../records/RecordUtils'
@@ -174,7 +174,8 @@ export async function updatePamRecordFields(
     recordType: string,
     fields: RecordField[],
     currentRevision: number,
-    storage: InMemoryStorage
+    storage: InMemoryStorage,
+    recordLinksAdd?: Records.IRecordLink[]
 ): Promise<void> {
     const recordKey = await storage.getKeyBytes(record.uid)
     if (!recordKey) {
@@ -195,7 +196,8 @@ export async function updatePamRecordFields(
             notes: recordData.notes || '',
         },
         currentRevision,
-        recordKey
+        recordKey,
+        recordLinksAdd
     )
 
     if (!updateResult.success) {

KeeperSdk/src/records/RecordOperations.ts

@@ -226,7 +226,8 @@ export async function updateRecord(
     recordUid: string,
     data: TypedRecordData,
     revision: number,
-    recordKey: Uint8Array
+    recordKey: Uint8Array,
+    recordLinksAdd?: Records.IRecordLink[]
 ): Promise<UpdateRecordResult> {
     if (!data.title || !data.title.trim()) {
         throw new KeeperSdkError('Record title is required.', 'missing_record_title')
@@ -252,6 +253,7 @@ export async function updateRecord(
         clientModifiedTime: Date.now(),
         revision,
         data: encryptedData,
+        ...(recordLinksAdd && recordLinksAdd.length > 0 ? { recordLinksAdd } : {}),
     }
 
     const request: Records.IRecordsUpdateRequest = {