Skip to content

Security Finding (5.3) SEC-020: AbstractController Serialize on Request Query Parameters #177

Description

@DyanGalih

Finding ID: SEC-020
Location: lib/Admin/Controller/AbstractController.php
CVSS: 5.3

Code uses serialize() on request-derived params to build cache keys. While used only for hashing now, this pattern is dangerous and may lead to unsafe behavior if logic changes.

Impact: Potential deserialization-related risks and unsafe practices.

Remediation (short): Use json_encode with JSON_THROW_ON_ERROR for stable, safer serialization for cache keys.

Reference: SECURITY_REVIEW.md

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions