Skip to content

Missing coverage around VkMemoryRangeBarriersInfoKHR #12923

Description

@spencer-lunarg

From #12920 / #12921 it is clear that there is likely missing things around VkMemoryRangeBarriersInfoKHR (added from VK_KHR_device_address_commands ) that need to be properly added/tested

This struct is just VkBufferMemoryBarrier2 be the VkBuffer was replaced with a VkDeviceAddressRangeKHR instead

  • We should have a single positive test that uses VkMemoryRangeBarriersInfoKHR
    • A test should also use it where multiple VkBuffer are tied to the same memory address range
  • CommandBufferSubState::UpdateEventWaitBarriers seems to be missing something
  • CommandBufferSubState::RecordBarriers2 seems to not be recording anything
  • CommandBuffer::RecordBarrierObjects doesn't seem to track it (via TrackDeviceAddressRange).
    • The AddChild here is used to know that if you delete/free a VkDeviceMemory that the command buffer is not invalid
  • CompareDependencyInfo is missing this, which might cause issues with VU 10788

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions