Skip to content

Newer version of mimaloc and removed unused function - #13109

Merged
spencer-lunarg merged 1 commit into
KhronosGroup:mainfrom
FilipNur:main
Sep 18, 2026
Merged

spencer-lunarg merged 1 commit into
KhronosGroup:mainfrom
FilipNur:main

Conversation

@FilipNur

Copy link
Copy Markdown
Contributor

Older version of mimalloc caused build errors.
IsHighIntegrity function was unused.

@FilipNur
FilipNur requested a review from a team as a code owner September 15, 2026 20:41
@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author FilipNur not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant

CLAassistant commented Sep 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@spencer-lunarg

Copy link
Copy Markdown
Contributor

Older version of mimalloc caused build errors.

Can you explain more on this?

We have had issues with mimalloc upgrades in the past, so if we are going to upgrade it

  1. It should be the only change (the IsHighIntegrity change is valid, but unrelated)
  2. I want record of why we did it

@FilipNur

Copy link
Copy Markdown
Contributor Author

@spencer-lunarg

  1. The mimalloc repository had error when compiling it. The error was about implicit casting between different pointer types. The version that was used previously still had that error. The version that this pull request uses is the newest version of mimalloc as of this moment, and it does not have that or any other compilation errors.
  2. During test compilation of this repo the warning about unused function came up, which was IsHighIntegrity. The VScode's search in all files did not find any other occurence of IsHighIntegrity other than the declaration of this function. If the function should stay in the code, or it's use is planned for the future, I will roll back the change that deletes it. If the IsHighIntegrity's code must stay in the source, then the warning about unused function can be suppressed by commenting out entire function.

Fixes build break with 3.3.2
@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author FilipNur not on autobuild list. Waiting for curator authorization before starting CI build.

@spencer-lunarg
spencer-lunarg merged commit 27c7f10 into KhronosGroup:main Sep 18, 2026
20 checks passed
@spencer-lunarg

Copy link
Copy Markdown
Contributor

@FilipNur sorry, I messed up, didn't run this change through CI and it is blowing stuff up now, going to quick revert #13158 and unblock CI, will try updating again, will need to figure out what is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants