sync: Fix submit time check - #13142
Merged
artem-lunarg merged 1 commit intoSep 17, 2026
Merged
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 123415. |
artem-lunarg
marked this pull request as ready for review
September 17, 2026 21:13
artem-lunarg
commented
Sep 17, 2026
| const ErrorObject& error_obj) const { | ||
| bool skip = false; | ||
| if (!syncval_settings.legacy_submit_time_validation) { | ||
| if (!syncval_settings.IsSubmitTimeProcessingEnabled()) { |
Contributor
Author
There was a problem hiding this comment.
IsSubmitTimeProcessingEnabled checks both legacy_submit_time_validation and new full_validation option. Found this when tried to benchmark with full validation enabled and everything got slower instead of faster and it was because of this.
Collaborator
|
CI Vulkan-ValidationLayers build # 24544 running. |
spencer-lunarg
approved these changes
Sep 17, 2026
Collaborator
|
CI Vulkan-ValidationLayers build # 24544 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.