Skip to content

sync: Fix submit time check #13142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artem-lunarg merged 1 commit into from
Sep 17, 2026
+8 −8
Merged

sync: Fix submit time check #13142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions layers/sync/sync_validation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,7 +2337,7 @@ void SyncValidator::PostCallRecordDeviceWaitIdle(VkDevice device, const RecordOb
bool SyncValidator::PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR* pPresentInfo,
const ErrorObject& error_obj) const {
bool skip = false;
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {

@artem-lunarg artem-lunarg Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsSubmitTimeProcessingEnabled checks both legacy_submit_time_validation and new full_validation option. Found this when tried to benchmark with full validation enabled and everything got slower instead of faster and it was because of this.

return skip;
}
std::lock_guard lock_guard(queue_mutex_);
Expand Down Expand Up @@ -2421,15 +2421,15 @@ uint32_t SyncValidator::SetupPresentInfo(const VkPresentInfoKHR& present_info, B
void SyncValidator::PostCallRecordAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
VkSemaphore semaphore, VkFence fence, uint32_t* pImageIndex,
const RecordObject& record_obj) {
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return;
}
RecordAcquireNextImageState(device, swapchain, timeout, semaphore, fence, pImageIndex, record_obj);
}

void SyncValidator::PostCallRecordAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR* pAcquireInfo,
uint32_t* pImageIndex, const RecordObject& record_obj) {
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return;
}
RecordAcquireNextImageState(device, pAcquireInfo->swapchain, pAcquireInfo->timeout, pAcquireInfo->semaphore,
Expand Down Expand Up @@ -2710,7 +2710,7 @@ bool SyncValidator::PropagateTimelineSignals(SignalsUpdate& signals_update) {
}

void SyncValidator::PostCallRecordGetFenceStatus(VkDevice device, VkFence fence, const RecordObject& record_obj) {
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return;
}
if (record_obj.result == VK_SUCCESS) {
Expand All @@ -2721,7 +2721,7 @@ void SyncValidator::PostCallRecordGetFenceStatus(VkDevice device, VkFence fence,

void SyncValidator::PostCallRecordWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence* pFences, VkBool32 waitAll,
uint64_t timeout, const RecordObject& record_obj) {
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return;
}
if ((record_obj.result == VK_SUCCESS) && ((VK_TRUE == waitAll) || (1 == fenceCount))) {
Expand All @@ -2735,7 +2735,7 @@ void SyncValidator::PostCallRecordWaitForFences(VkDevice device, uint32_t fenceC
bool SyncValidator::PreCallValidateSignalSemaphore(VkDevice device, const VkSemaphoreSignalInfo* pSignalInfo,
const ErrorObject& error_obj) const {
bool skip = false;
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return skip;
}
// Although SignalSemaphore does not run on the queue, the signalling can resolve
Expand Down Expand Up @@ -2778,7 +2778,7 @@ bool SyncValidator::ProcessSignalSemaphore(VkDevice device, const VkSemaphoreSig

void SyncValidator::PostCallRecordWaitSemaphores(VkDevice device, const VkSemaphoreWaitInfo* pWaitInfo, uint64_t timeout,
const RecordObject& record_obj) {
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return;
}
const bool wait_all = pWaitInfo->semaphoreCount == 1 || (pWaitInfo->flags & VK_SEMAPHORE_WAIT_ANY_BIT) == 0;
Expand All @@ -2796,7 +2796,7 @@ void SyncValidator::PostCallRecordWaitSemaphoresKHR(VkDevice device, const VkSem

void SyncValidator::PostCallRecordGetSemaphoreCounterValue(VkDevice device, VkSemaphore semaphore, uint64_t* pValue,
const RecordObject& record_obj) {
if (!syncval_settings.legacy_submit_time_validation) {
if (!syncval_settings.IsSubmitTimeProcessingEnabled()) {
return;
}
if (record_obj.result == VK_SUCCESS) {
Expand Down
Loading