layers: Move Draw time Dynamic Checks for SO - #13152
Open
spencer-lunarg wants to merge 1 commit into
Open
spencer-lunarg wants to merge 1 commit into
spencer-lunarg wants to merge 1 commit into
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 124306. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24558 running. |
spencer-lunarg
force-pushed
the
spencer-lunarg-move-pipeline-to-shader-object
branch
from
September 18, 2026 16:54
fbcec17 to
d801351
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 124413. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24565 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24565 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-move-pipeline-to-shader-object
branch
from
September 19, 2026 00:52
d801351 to
9763715
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 124949. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24576 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24576 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found these VUs were only validating in pipelines, but also should in shader objects, so made these 3 spec MR
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/8528/
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/8529/
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/8530/
and now in 1.4.363 the VUs are marked for ShaderObjects, this just moves the logic over and adds some tests
so basically
ValidateDrawDynamicStatePipelineValueis smaller and the next task is to not makeValidateDrawDynamicStateValuesuch a giant mess