tests: Allow valid Timeout result - #13154
Closed
spencer-lunarg wants to merge 1 commit into
Closed
spencer-lunarg wants to merge 1 commit into
spencer-lunarg wants to merge 1 commit into
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 124377. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24563 running. |
| uint32_t fault_counts = 0; | ||
| VkResult result = vk::GetDeviceFaultReportsKHR(device(), 0, &fault_counts, nullptr); | ||
| ASSERT_EQ(VK_SUCCESS, result); | ||
| ASSERT_TRUE(result == VK_TIMEOUT || result == VK_SUCCESS); |
Contributor
There was a problem hiding this comment.
Do we need this test then? it's called GetDeviceFaultReportsWithoutTimeout
Contributor
Author
There was a problem hiding this comment.
I need to talk with Samual again.... the whole ShaderAbort thing has been a disaster IMO, and seems a lack of testing/agreement how these device faults should work
... closing and going to figure this out
artem-lunarg
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RADV returns
VK_TIMEOUTwhich is valid